D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-08 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R120:408c6d6319ee: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-08 Thread Filip Fila
filipf updated this revision to Diff 53434. filipf added a comment. Subtract 2 from width so we don't get fringing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19478?vs=52994=53434 BRANCH master REVISION DETAIL

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-08 Thread Krešimir Čohar
rooty accepted this revision. rooty added a comment. There doesn't seem to be anything else to be done here REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: abetts, plasma-devel, jraleigh,

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-08 Thread Krešimir Čohar
rooty added a comment. i vote for no 2 / current diff REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-08 Thread Filip Fila
filipf added a comment. Now that the other patch is done, I come offering 2 solutions. **Solution 1: Mimic the action button circles' appearance** F6673176: Screenshot_20190308_122953.png F6673180: Screenshot_20190308_122851.png

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-04 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-03 Thread Filip Fila
filipf added a comment. In D19478#424055 , @ngraham wrote: > ...And now that that's landed, I think this can too. I would now wait until after D19479 so that we don't necessarily have dark and light

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-03 Thread Nathaniel Graham
ngraham added a comment. ...And now that that's landed, I think this can too. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is fine. It makes it even more important that we make the current user's avatar bigger though. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-02 Thread Filip Fila
filipf added a comment. There's a little bit of fringing around the white border so I can subtract 2 from the width? F6649343: image.png Left is before, right after. Doesn't quite solve it, but is a bit better. REPOSITORY R120 Plasma

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

2019-03-02 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Added in D16879 , the background circle was designed to work on a blurless login screen. Since