D19596: color monochrome icons to tooltip colors

ngraham added a comment. Nice! Would you mind doing the same for System Settings, which has the same code? Dolphin's Tooltip could use the same treatment too, see https://bugs.kde.org/show_bug.cgi?id=404858 REPOSITORY R102 KInfoCenter REVISION DETAIL

D19596: color monochrome icons to tooltip colors

This revision was automatically updated to reflect the committed changes. Closed by commit R102:23fa36983170: color monochrome icons to tooltip colors (authored by mart). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19596?vs=53725=53726 REVISION DETAIL

D19596: color monochrome icons to tooltip colors

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. It's gorgeous! sheepit REPOSITORY R102 KInfoCenter BRANCH phab/iconColor REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: broulik, ngraham,

D19596: color monochrome icons to tooltip colors

mart updated this revision to Diff 53725. mart added a comment. - unbreak category icons REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19596?vs=53724=53725 BRANCH phab/iconColor REVISION DETAIL https://phabricator.kde.org/D19596 AFFECTED FILES

D19596: color monochrome icons to tooltip colors

mart updated this revision to Diff 53724. mart added a comment. - icon()->iconName() REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19596?vs=53369=53724 BRANCH phab/iconColor REVISION DETAIL https://phabricator.kde.org/D19596 AFFECTED FILES

D19596: color monochrome icons to tooltip colors

mart added a comment. In D19596#427074 , @sitter wrote: > Following Kai's question... wouldn't KIconLoader::global make the entire static obsolete? we need a second one, not the one used by the app, because we are altering how it

D19596: color monochrome icons to tooltip colors

sitter added a comment. Following Kai's question... wouldn't KIconLoader::global make the entire static obsolete? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19596: color monochrome icons to tooltip colors

broulik added a comment. What's the need for this wrapper class rather than just making the `KIconLoader` global static? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen,

D19596: color monochrome icons to tooltip colors

mart added a comment. In D19596#426701 , @sitter wrote: > The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get

D19596: color monochrome icons to tooltip colors

sitter added a comment. The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get called. So what I am thinking is these changes: ::icon goes away in favor of

D19596: color monochrome icons to tooltip colors

mart added a comment. In D19596#426652 , @sitter wrote: > I think what we need is to change `KcmTreeItem::icon()` (and its derived class KcmCategoryItem) to `QString KcmTreeItem::iconName()` and use that on the KDE::icon call. And

D19596: color monochrome icons to tooltip colors

ngraham added a comment. Sweet, could you do the same thing for System Settings' tooltip too? It's a fork of this code (or maybe the reverse is true). REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: ngraham, plasma-devel,

D19596: color monochrome icons to tooltip colors

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. That seems to break the category icons because `KDE::icon(menuItem->kcm().icon()` is only working on Kcm entries, while KcmCategory entries overload `::icon` with divergent

D19596: color monochrome icons to tooltip colors

mart added a comment. F6670098: image.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19596: color monochrome icons to tooltip colors

mart created this revision. mart added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when the tooltips are dark, monochrome icons can be black on black use kiconloader with a custom