D19651: Improve the look of the Application Style KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a946944edb20: Improve the look of the Application Style KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53803&id=53806 RE

D19651: Improve the look of the Application Style KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Code is sane too. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg, rooty, ngraham Cc: ngraham, brou

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53803. GB_2 added a comment. Update Quick Help text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53798&id=53803 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES kcm

D19651: Improve the look of the Application Style KCM UI

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmstyle.cpp:174 > +setQuickHelp( i18n("This module allows you to modify the visual > appearance " > + "of user interface elements

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53798. GB_2 added a comment. Update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53792&id=53798 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES kcms/style/

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53792. GB_2 added a comment. Implement Rooty's suggestions and update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53747&id=53792 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#430117 , @rooty wrote: > Please consider abbreviating the labels: > > - dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons) > - dropping the word location (it's i

D19651: Improve the look of the Application Style KCM UI

broulik added a comment. +1 on the new clean layout and for getting rid of tabs REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, Zren

D19651: Improve the look of the Application Style KCM UI

rooty added a comment. Please consider abbreviating the labels: - dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons) - dropping the word location (it's implicit) - substituting the word text with the word label (it's more accurate) O

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53747. GB_2 added a comment. Improve preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53635&id=53747 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES kcms/style

D19651: Improve the look of the Application Style KCM UI

abetts added a comment. Is there any way that we can make the preview window have more right and left margins? When presented like this, it seems like it is actually another module that users interact with. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1965

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428459 , @GB_2 wrote: > In D19651#428458 , @ndavis wrote: > > > Can it have the same default width as the toolbar text location comboboxes? > > > Yeah, I can try

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53635. GB_2 added a comment. Check if configure button should be enabled after clicking "Defaults" and rename "cbStyle" to "comboStyle" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53592&id=53635 BRANCH

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428458 , @ndavis wrote: > Can it have the same default width as the toolbar text location comboboxes? Yeah, I can do that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19

D19651: Improve the look of the Application Style KCM UI

ndavis added a comment. Can it have the same default width as the toolbar text location comboboxes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428453 , @ndavis wrote: > Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? Yes, it adjusts itself to the width of the longest item automatically. REPOSIT

D19651: Improve the look of the Application Style KCM UI

ndavis added a comment. Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53592. GB_2 added a comment. Rename style preview checkbox from "Check box" to "Checkbox" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53591&id=53592 BRANCH master REVISION DETAIL https://phabricato

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53591. GB_2 added a comment. Clean up style preview UI file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53589&id=53591 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FIL

D19651: Improve the look of the Application Style KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, merge the two tabs into one page and make the KCM look better. F6680804: Improved