This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bbd7fcb3a300: [Splash KCM] Use InlineMessage for testing
error (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19752?vs=53864&id=57850
ngraham added a comment.
I think this is useful enough now, and we can tweak the error message later.
:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19752
To: broulik, #plasma, #vdg, filipf
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragree
broulik added a comment.
> Could the message include some hints of what failed?
I don't know what failed, I just know the ksplash app crashed or got killed.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19752
To: broulik, #plasma, #vdg, filipf
Cc: ngrah
ngraham added a comment.
Yeah I agree, this isn't a very actionable error message. What is the user
supposed to make of it or do next?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19752
To: broulik, #plasma, #vdg, filipf
Cc: ngraham, abetts, filipf, plasma
abetts added a comment.
Could the message include some hints of what failed? Maybe the theme name?
Something like:
"Failed to test Adwaita splash screen, please check theme"
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19752
To: broulik, #plasma, #vdg
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.
Visually I don't think there's anything to object to, and this is a useful
message to have. The wording seems fine. Someone should also confirm that the
code is sane.
REPOSITORY
R119 Pla
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
When testing a splash screen fails, a message box appears. This changes it to
an `InlineLabel
