D19802: [comic] Modernize configuration windows

This revision was automatically updated to reflect the committed changes. Closed by commit R114:f2647deeeac7: [comic] Modernize configuration windows (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54453=54486 REVISION

D19802: [comic] Modernize configuration windows

abetts added a comment. > You mean "General", "Appearance" etc. right? Yeah that happens when windows are stretched horizontally, but the window wouldn't be much narrower IRL tbh. Kirigami's FormLayout is center aligned and the category's title always remains left aligned. They're pretty

D19802: [comic] Modernize configuration windows

filipf added a comment. In D19802#435421 , @abetts wrote: > The title labels appear to be very far from the content. Is that just the size on the images or does it actually look very far when the config screen is full size? You mean

D19802: [comic] Modernize configuration windows

abetts added a comment. The title labels appear to be very far from the content. Is that just the size on the images or does it actually look very far when the config screen is full size? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19802 To: filipf,

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54453. filipf marked an inline comment as done. filipf added a comment. Change strings according to Nate's suggestions REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54254=54453 BRANCH

D19802: [comic] Modernize configuration windows

ngraham added inline comments. INLINE COMMENTS > filipf wrote in configAdvanced.qml:55 > It's always the plural now, but I also realized we shouldn't be using > singular if value is 1 because some Slavic languages use singular with 21, > 31, etc. Yep, even if the quantity will always be more

D19802: [comic] Modernize configuration windows

filipf marked 7 inline comments as done. filipf added inline comments. INLINE COMMENTS > ngraham wrote in configAdvanced.qml:55 > The way you do this properly is as follows, with `i18ncp()`: > > text: i18ncp("@item:valuesuffix spacing to number + unit", " strip per > comic", "strips per

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54254. filipf added a comment. avoid using headings, fix spinbox strings REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54001=54254 BRANCH modernized-comic-settings (branched from master) REVISION

D19802: [comic] Modernize configuration windows

ngraham added a subscriber: mart. ngraham added a comment. In D19802#432171 , @filipf wrote: > Definitely some silly mistakes in there, thanks for showing me how to do it right! > > As for the looks, I'm struggling with liking the placement

D19802: [comic] Modernize configuration windows

filipf added a comment. Definitely some silly mistakes in there, thanks for showing me how to do it right! As for the looks, I'm struggling with liking the placement of the headings when Kirigami.FormData.label is used, hence the row layouts. Case in point: F6696611:

D19802: [comic] Modernize configuration windows

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > configAdvanced.qml:55 > +Controls.Label { > +text: maxComicLimit.value !==1 ? i18nc("@item:valuesuffix > spacing to number + unit", "

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54001. filipf added a comment. 1 strips per comic -> 1 strip per comic REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54000=54001 BRANCH modernized-comic-settings (branched from master) REVISION

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54000. filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added a comment. when value for minutes is 1 use "min" instead of "mins", when value for days is 1 use "day" instead of "days" REPOSITORY R114

D19802: [comic] Modernize configuration windows

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH modernized-comic-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D19802