D19822: [Task Manager] Toggle mute when the audio indicator is clicked

This revision was automatically updated to reflect the committed changes. Closed by commit R119:da268696a6af: [Task Manager] Toggle mute when the audio indicator is clicked (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 69128. GB_2 added a comment. Remove unneeded properties REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=69127=69128 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 69127. GB_2 added a comment. Move into AudioStream REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65691=69127 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Approach is fine, but please move the MouseArea into the audioStreamIconLoader's source component so it's not always instantiated even when it's not needed. :) REPOSITORY R119

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham accepted this revision. ngraham added a comment. Works and looks great to me. @hein, are you okay with this now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 65691. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65509=65691 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. This patch doesn't apply anymore. I think something went wrong with adding that last change. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 65509. GB_2 added a comment. Use Plasma highlight effect REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=55003=65509 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. In D19822#442630 , @filipf wrote: > Just throwing out another possible solution: the PlasmaComponents Highlight thingy: > > F6747233: Screenshot_20190403_005556.png > >

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. So um, any chance we can move forward with this in some capacity? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. Just throwing out another possible solution: the PlasmaComponents Highlight thingy: F6747233: Screenshot_20190403_005556.png F6747232: Screenshot_20190403_005453.png Might be

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. In D19822#442584 , @ngraham wrote: > Hmm, while the red highlight effect is pretty and distinctive, typically we don't telegraph what will happen when clicked using an item's hover effect. Though it's more boring and

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. Hmm, while the red highlight effect is pretty and distinctive, typically we don't telegraph what will happen when clicked using an item's hover effect. Though it's more boring and conventional, I would recommend using the typical effect. :) REPOSITORY R119 Plasma

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a comment. About the icon issue, IconItem by default uses the icon theme overlay from the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind of tricky - with Breeze we could totally make them match, but other Plasma themes would have issues. A long

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. The highlight effect provided by `PlasmaCore.IconItem` is only visible when used with dark or colourful icons: F6746966: Mute5.gif F6746965: Mute4.gif I also tried reducing the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf resigned from this revision. filipf added a comment. Highlight color is nice, but in my tests I really like having red for the muting because it gets the point across that a disabling action will be triggered. Therefore the code I have now is: `color: mouseArea.containsMouse?

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#442125 , @hein wrote: > I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :) one important thing, it should be

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a comment. I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#439167 , @hein wrote: > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#437687 , @filipf wrote: > I still think we should make it configurable. We'd want to be able to avoid situations with parents or a newbies going something like: "I was watching/listening to X and your darn Linux

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#437684 , @faridb wrote: > In D19822#437680 , @ngraham wrote: > > > Also, it would be nice if you also work on making the volume indicators smaller and always in the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#439297 , @hein wrote: > A possible improvement to make here is to make the indicator visually react to hover by recoloring the icon, to teach that it's seperately interactive and will do something different than

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 55003. faridb added a comment. - Revert "[Task Manager] Make mute/unmute behaviour configurable" In D19822#439724 , @hein wrote: > Back to work: For this patch to proceed further, please remove the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a subscriber: mart. hein added a comment. rooty, your behavior in this thread has been extremely aggressive, disrespectful and uncollaborative. I'd like to ask you to stop at this point and not participate futher, as well as in any future threads related to the Task Manager

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. Hey guys, I propose that we shelve the discussion about making this optional since it seems like we all agree that it should be on by default. In my experience, focusing on the points of //dis//agreement makes it likely that nothing gets landed, and relationships

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. > In projects where maintenance is lacking you will notice a trend towards options sprawl for that reason. That doesn't make sense. It might mean there's a lack of direction but not necessarily a lack of maintenance. Whether expansion leads to "option sprawl"

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. > In D19822#439336 , @filipf wrote: > >> As for options overload, based on the reasoning above and the fact that we've recently split up the options and that we have space, I don't agree that this should be approached

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a comment. In D19822#439336 , @filipf wrote: > As for options overload, based on the reasoning above and the fact that we've recently split up the options and that we have space, I don't agree that this should be approached through

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. Would something like this work? F6725968: AudioHover We would need to port the PlasmaCore.IconItem to Kirigami.Icon to support the color property. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. In D19822#439568 , @ngraham wrote: > In D19822#439567 , @faridb wrote: > > > In D19822#439396 , @ngraham wrote: > > > > > it

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. In D19822#439567 , @faridb wrote: > In D19822#439396 , @ngraham wrote: > > > it would be nice if the "playing audio" icon itself changed to reflect the current status. >

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. In D19822#439195 , @rooty wrote: > I like this change I'd just prefer it if you could post screenshots in the test plan section? I added a screen recording to the test plan. In D19822#439396

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. +1 for refining the visuals to make it clear when a click will activate the Task vs mute/unmute its audio streams. Also now that I think of it, it would be nice if the "playing audio" icon itself changed to reflect the current status. I'll stay out of the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. > The suggestion about the hover effect though is a nice one +1 I wonder if we should make it turn gray when hovering over the option and stay gray while muted, or just turn gray and then once you move your cursor away it gets its color back regardless of whether

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. I made the suggestion to have an option not because there might be something wrong with the feature, but because there is a subset of users who have a harder time finding their way around the UI - the non-tech say people and/or (now that I think of it) perhaps those

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. > No, it's not. Yeah it is :D > Trivial options have a lot of cost attached to them: They make a UI noisier and more intimidating, and therefore less appealing. They also make it less effective by making it harder to find what you're looking for, as you have

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. > This is a specious argument. No, it's not. Trivial options have a lot of cost attached to them: They make a UI noisier and more intimidating, and therefore less appealing. They

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. In D19822#439167 , @hein wrote: > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. In D19822#439167 , @hein wrote: > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a comment. I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go. Firefox gets away without the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54823. faridb marked 4 inline comments as done. faridb added a comment. - [Task Manager] Enable ability to mute tasks by default - [Task Manager] Change wording in config ui REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added inline comments. INLINE COMMENTS > ngraham wrote in main.xml:99 > I'd have this on by default. +1 for having it on by default > ConfigAppearance.qml:72 > > +RowLayout { > +// Indent the option as it depends on the previous one Putting the option in the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added inline comments. INLINE COMMENTS > main.xml:99 > + Whether to mute/unmute applications when the audio streams > indicator is clicked. > + false > + I'd have this on by default. > ConfigAppearance.qml:80 > +id: audioStreamsMute > +

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54735. faridb added a comment. - [Task Manager] Make mute/unmute behaviour configurable I added the possibility to enable/disable this behaviour in the plasmoid configuration. I added it to the 'Appearance' section even though it's a behaviour.

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. Cool! I think the top-right corner would be more appropriate though, as long as there's no other badge there. Also, the volume indicator badge shouldn't expand the geometry of the item. In D19822#437687 , @filipf wrote:

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. I still think we should make it configurable. We'd want to be able to avoid situations with parents or a newbies going something like: "I was watching/listening to X and your darn Linux stopped playing sound!". REPOSITORY R119 Plasma Desktop BRANCH

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. In D19822#437680 , @ngraham wrote: > Also, it would be nice if you also work on making the volume indicators smaller and always in the corner. This is what it looks like with a small icon in the corner:

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham accepted this revision. ngraham added a comment. LGTM. @broulik? Also, it would be nice if you also work on making the volume indicators smaller and always in the corner. REPOSITORY R119 Plasma Desktop BRANCH taskmanager-mute (branched from master) REVISION DETAIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54731. faridb added a comment. - [Task Manager] Remove unnecessary braces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=54077=54731 BRANCH taskmanager-mute (branched from master) REVISION DETAIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this makes sense. INLINE COMMENTS > Task.qml:505 > +enabled: parent.shown > +onClicked: { toggleMuted() } > +} Don't need braces here REPOSITORY

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mvourlakos added a comment. In D19822#435735 , @filipf wrote: > This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that matters is that it can be configured; by default it could be turned on IMO. REPOSITORY

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mvourlakos added a comment. I don't know if this can be of any help but this is supported by Latte dock, including scroll wheel to increase/decrease the specific audio stream volume REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. In D19822#433103 , @faridb wrote: > - Use a smaller icon for the audio indicator and place it in one of the corners of the task button and not in the centre I would like this, especially if we put it inside an

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. Yes, you could accidentally mute an application when using Icons-Only Task Manager. As you can see below, the audio indicator is pretty close to the centre of the task button, which is where you would usually click to activate that task: F6698588:

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. On the other hand, the radio is infinite when the indicator isn't visible on an IOTM due to https://bugs.kde.org/show_bug.cgi?id=381656 :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb Cc: ngraham, broulik,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

broulik added a comment. Not sure, it might be accidentally triggered which is why I didn't implement this. Especially in icon tasks where the audio icon to task item ratio is quite large. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb Cc:

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. faridb requested review of this revision. REVISION SUMMARY The task manager shows an indicator on tasks playing audio (when enabled in the settings). This patch adds the ability to