rooty added a comment.
Hey I know this has landed already but how do you feel about the word
Retrieving instead of Fetching?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D19825
To: ngraham, apol, #vdg, #discover_software_store
Cc: rooty, abetts,
abetts added a comment.
+1
Maybe the icon can be smaller, but in principle, yes!
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D19825
To: ngraham, apol, #vdg, #discover_software_store
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:95c39a6f7f2b: Improve update states UI (authored by
ngraham).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19825?vs=54107=54111
REVISION DETAIL
ngraham updated this revision to Diff 54107.
ngraham marked 2 inline comments as done.
ngraham added a comment.
Improve a string and find the property properly
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19825?vs=54087=54107
BRANCH
apol added a comment.
conceptual +1
INLINE COMMENTS
> UpdatesPage.qml:152
> +Layout.maximumHeight: Layout.minimumHeight
> +visible: isBusy
> +}
use `page.isBusy` so it doesn't have to start looking for the symbol all over
the place
>
ngraham updated this revision to Diff 54087.
ngraham added a comment.
Don't show the icon when there are any updates
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19825?vs=54084=54087
BRANCH
improve-update-states (branched from master)
ngraham created this revision.
ngraham added reviewers: apol, VDG, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
- Add a busy indicator when something is refreshing or checking
-
