D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham commandeered this revision. ngraham edited reviewers, added: hallas; removed: ngraham. ngraham added a comment. Done in D26139 . REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: ngraham, #vdg, #breeze, abetts,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. In D19890#577833 , @hpereiradacosta wrote: > As a side remark: did you check how it looks when one selects "text under icon" or "text beside icon" for toolbar button ? There is no problem with text, even if you

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hpereiradacosta added a comment. As a side remark: did you check how it looks when one selects "text under icon" or "text beside icon" for toolbar button ? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts, ndavis Cc:

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. In D19890#577221 , @hpereiradacosta wrote: > Confused about 2: I thought icon size was the same for flat and non flat toolbuttons (see oxygen-demo5, buttons tab) Most normal buttons use 16px icons while flat

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. We could also do these things: - In Dolphin, mimic the back/forward buttons in Firefox/Chromium/Falkon by making the right click menu provide the history instead of the normal menu for manipulating the toolbar. Inconsistent with what we normally do, but not

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hpereiradacosta added a comment. In D19890#577204 , @ndavis wrote: > Ok, so there is an overlap problem, but it's quite rare. It happens when an icon uses 100% of the available space in the bottom right corner (or left with RTL, I think). >

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. I honestly think ignoring the problem is the best solution, because it's not even really a problem in practice: the vast, overwhelming majority of icons use correct margins, especially action icons which are going to be the ones used 99.9% of the time in buttons

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. Ok, so there is an overlap problem, but it's quite rare. It happens when an icon uses 100% of the available space in the bottom right corner (or left with RTL, I think). Here I changed the stop icon in KDevelop to the icon for Codelite: F7817068:

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. All right, if you're working on it, I won't bug you. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts, ndavis Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. In D19890#577135 , @ngraham wrote: > I'm not sure how to do that in the Breeze style here; can you show me? Ehh, I'm already working on it and figuring it out as I go. I have to move points in a vector around,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. One problem I see with this is that the tops of the down arrows are a bit blurry. The way to fix that is to increase the size just enough that they fill the pixel. The bottom point should also have a MiterJoin so that it isn't a horizontal flat tip on high DPI

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. I'm not sure how to do that in the Breeze style here; can you show me? REPOSITORY R31 Breeze BRANCH draw_small_arrow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts Cc: ndavis, abetts,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

abetts accepted this revision. abetts added a comment. Love it! Move forward! REPOSITORY R31 Breeze BRANCH draw_small_arrow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts Cc: abetts, hpereiradacosta, plasma-devel,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. In retrospect, I think I reverted this too quickly in response to concerns. As expected, we have been receiving user complaints that the arrows in the corners of Dolphin's back and

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. Are you +1'ing the original patch or the fact that I reverted it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: abetts, hpereiradacosta, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: abetts, hpereiradacosta, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. Reverted in c9aa535863e09bf736b1fb64c182b93530780c5d REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: hpereiradacosta,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. Yes I checked, and they looked fine. However I'm considering reverting the patch anyway because I'm un-convincing myself that it was needed at all to properly support D19311 . REPOSITORY R31 Breeze REVISION DETAIL

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hpereiradacosta added a comment. Did anyone check how this patch look with other icons than those in the screenshot ? E.g. the preview icon in dolphin, or list sorting or search icons ? Does the new arrow overlap with the said icons ? REPOSITORY R31 Breeze REVISION DETAIL

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hallas closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. ...Or 96 hours. :) Thanks, this looks perfect to me. REPOSITORY R31 Breeze BRANCH draw_small_arrow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19890 To: