D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car
meven added a comment. When AC is plugged: F6770195: ac-plugged.png When AC is unplugged: F6770194: ac-unplugged.png I have noticed that sometimes the remaining time is not available. In which case the

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car
meven updated this revision to Diff 56125. meven added a comment. No need to keep stored localy the batterRemainingTime REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20492?vs=56123&id=56125 BRANCH arcpatch-D20492 REVISION DETAIL https://phabricato

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car
meven updated this revision to Diff 56123. meven added a comment. Fix formatting of details REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20492?vs=56113&id=56123 BRANCH arcpatch-D20492 REVISION DETAIL https://phabricator.kde.org/D20492 AFFECTED F

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-13 Thread Méven Car
meven updated this revision to Diff 56113. meven added a comment. Improve wording REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20492?vs=56063&id=56113 BRANCH arcpatch-D20492 REVISION DETAIL https://phabricator.kde.org/D20492 AFFECTED FILES CMa

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > powerdevilcore.cpp:635 > +if (m_batteryRemainingTime > 0) { > +detail = i18n("You need %s to fill the battery", > KFormat().formatDuration(m_batteryRemainingTime, KFormat::HideSeconds)); > +} else { `Remain

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Méven Car
meven added a comment. In D20492#448825 , @ngraham wrote: > Screenshots would be nice. :) That's my intent, we can yet talk about wording. I can now move forward after recompiling everything... REPOSITORY R122 Powerdevil REVISION

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Nathaniel Graham
ngraham added a comment. Screenshots would be nice. :) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D20492 To: meven, #plasma_workspaces Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,