D20533: Display two shortcuts to the kcm Energy Information from the battery applet

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham, broulik, #vdg Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:143 > if (batterymonitor.kcmsAuthorized) { > +plasmoid.setAction("energyinformationkcm", i18n(" > Information..."), "battery"); > plasmoid.setAction("powerdevilkcm", i18n(" Power >

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven planned changes to this revision. meven added a comment. In D20533#450777 , @ngraham wrote: > In D20533#450711 , @broulik wrote: > > > -1 please let's cleanup / rewrite the energy info kcm

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

ngraham added a comment. In D20533#450711 , @broulik wrote: > -1 please let's cleanup / rewrite the energy info kcm first using Kirigami FormLayout and kcm components before making it prominently accessible from the UI Yeah, that makes

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

broulik added a comment. -1 please let's cleanup / rewrite the energy info kcm first using Kirigami FormLayout and kcm components before making it prominently accessible from the UI REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

ngraham added a reviewer: VDG. ngraham added a comment. I like having it in the context menu. Putting it in the expanded pop-up I'm less sure about, because the icon isn't as recognizable and maybe we might be cluttering the view up too much? REPOSITORY R120 Plasma Workspace REVISION

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven added a comment. The energy info kcm would need some attention though. kcmshell5 kcm_energyinfo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven updated this revision to Diff 56236. meven marked 2 inline comments as done. meven added a comment. Capitalization REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56235=56236 BRANCH arcpatch-D20533 REVISION DETAIL

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > apol wrote in batterymonitor.qml:106 > Typo? kcm_energyinfo vs kcms_energyinfo Thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven updated this revision to Diff 56235. meven added a comment. Typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56183=56235 BRANCH arcpatch-D20533 REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

apol added inline comments. INLINE COMMENTS > batterymonitor.qml:106 > +readonly property var kcm_energyinfo: ["kcm_energyinfo.desktop"] > +readonly property bool kcmEnergyInformationAuthorized: > KCMShell.authorize(kcms_energyinfo).length > 0 > + Typo? kcm_energyinfo vs

D20533: Display two shortcuts to the kcm Energy Information from the battery applet.

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES