D20851: [Pager] Improve label legibility

2019-04-30 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d09d4d52e161: [Pager] Improve label legibility (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57220=57258 REVISION DETAIL

D20851: [Pager] Improve label legibility

2019-04-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 57220. ngraham added a comment. Revert unnecessary change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57219=57220 BRANCH improve-pager-label-legibility (branched from master) REVISION DETAIL

D20851: [Pager] Improve label legibility

2019-04-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 57219. ngraham added a comment. Yeah it's way better without any visual changes except just moving the label to the top REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57063=57219 BRANCH

D20851: [Pager] Improve label legibility

2019-04-26 Thread Noah Davis
ndavis added a comment. In D20851#456931 , @ngraham wrote: > [...] In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve this. Yes, but this is

D20851: [Pager] Improve label legibility

2019-04-26 Thread Filip Fila
filipf added a comment. An outline could work, but maybe not at 100% opacity. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20851 To: ngraham, #vdg, #plasma Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20851: [Pager] Improve label legibility

2019-04-26 Thread Andres Betts
abetts added a comment. In D20851#456936 , @ngraham wrote: > In D20851#456932 , @abetts wrote: > > > I agree with this too. Do you think it would be too weird of other methods are used? For example:

D20851: [Pager] Improve label legibility

2019-04-26 Thread Nathaniel Graham
ngraham added a comment. In D20851#456932 , @abetts wrote: > I agree with this too. Do you think it would be too weird of other methods are used? For example: > > - Use a more legible font that is independent from system font > - Use

D20851: [Pager] Improve label legibility

2019-04-26 Thread Andres Betts
abetts added a comment. In D20851#456931 , @ngraham wrote: > Well, I find it almost impossible to read the text with the status quo version when there are a bunch of window outlines. In the first screenshot you can see that the number "1" is

D20851: [Pager] Improve label legibility

2019-04-26 Thread Nathaniel Graham
ngraham added a comment. Well, I find it almost impossible to read the text with the status quo version when there are a bunch of window outlines. In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve

D20851: [Pager] Improve label legibility

2019-04-26 Thread Andres Betts
abetts added a comment. In D20851#456903 , @ndavis wrote: > To me, the white text with the shadows doesn't really improve legibility and just looks "off". For some reason, shadow behind small text messes with my eyes and makes it harder to

D20851: [Pager] Improve label legibility

2019-04-26 Thread Noah Davis
ndavis added a comment. To me, the white text with the shadows doesn't really improve legibility and just looks "off" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20851 To: ngraham, #vdg, #plasma Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20851: [Pager] Improve label legibility

2019-04-26 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, when displaying pager labels (either number or name), text legibility is often