D20969: [potd] Modernize configuration settings

This revision was automatically updated to reflect the committed changes. Closed by commit R114:13609c5ae7b9: [potd] Modernize configuration settings (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20969?vs=57557&id=57734 REVISION D

D20969: [potd] Modernize configuration settings

ngraham added a comment. Thanks, shipit! REPOSITORY R114 Plasma Addons BRANCH modernize-potd-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D20969: [potd] Modernize configuration settings

filipf added a comment. In D20969#461288 , @ngraham wrote: > Few changes needed to the Description before landing: > > - Is the `NOTE` still accurate? I don't see that behavior anymore. > - Also we're no longer porting to QQC2 Fixed.

D20969: [potd] Modernize configuration settings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Few changes needed to the Description before landing: - Is the `NOTE` still accurate? I don't see that behavior anymore. - Also we're no longer porting to QQC2 REPOSITORY R114 Pla

D20969: [potd] Modernize configuration settings

filipf added a comment. In D20969#460470 , @ngraham wrote: > Hmm, setting a maximum width is kind of lousy for really long strings though, because they get elided. I think it might make more sense to make sure that the window expands to accomoda

D20969: [potd] Modernize configuration settings

filipf updated this revision to Diff 57557. filipf added a comment. change string "Providers:" to "Provider:" REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20969?vs=57499&id=57557 BRANCH modernize-potd-config (branched from master) REVISION DETAI

D20969: [potd] Modernize configuration settings

ngraham added a comment. Hmm, setting a maximum width is kind of lousy for really long strings though, because they get elided. I think it might make more sense to make sure that the window expands to accomodate a wide combobox, and them trim down that particular string. It's just way too lo

D20969: [potd] Modernize configuration settings

filipf added a comment. In D20969#460433 , @ngraham wrote: > Nice job. But I shudder to think of how long this string must be in German or Brazilian Portuguese: > F6806865: Screenshot_20190503_123158.png

D20969: [potd] Modernize configuration settings

ngraham added a comment. Nice job. But I shudder to think of how long this string must be in German or Brazilian Portuguese: F6806865: Screenshot_20190503_123158.png INLINE COMMENTS > config.qml:76 > +implicitWidth: Math.max(providerTextMetri

D20969: [potd] Modernize configuration settings

filipf updated this revision to Diff 57499. filipf added a comment. minor cleanup REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20969?vs=57498&id=57499 BRANCH modernize-potd-config (branched from master) REVISION DETAIL https://phabricator.kde.

D20969: [potd] Modernize configuration settings

filipf updated this revision to Diff 57498. filipf added a comment. - go back to using QQC1 comboboxes - match the width of the QQC1 comboboxes with the top 2 QQC2 comoboxes - if a menu entry is longer than aforementioned width, resize the combobox REPOSITORY R114 Plasma Addons CHANGES

D20969: [potd] Modernize configuration settings

filipf added a comment. I could set the width of the QQC1 combobox to match the QQC2 ones above, but it won't get resized if a wider entry is selected (as is the case with QQC2). Thoughts on how to proceed? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969

D20969: [potd] Modernize configuration settings

abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20969: [potd] Modernize configuration settings

ngraham added a comment. Hmm, that seems non-ideal. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D20969: [potd] Modernize configuration settings

filipf added a comment. QQC1 Comboboxes: F6806609: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D20969: [potd] Modernize configuration settings

filipf added a comment. In D20969#459871 , @davidedmundson wrote: > If you upload without the combobox changes, I'll be happy to click ship it. The problem though I've run into with having QQC1 Combobox in the Form Layout is all th

D20969: [potd] Modernize configuration settings

davidedmundson added a comment. If you upload without the combobox changes, I'll be happy to click ship it. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel

D20969: [potd] Modernize configuration settings

ngraham added a comment. If it's not getting set on load, the problem is probably somewhere in those funky for loops to get and set the value of the combobox. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: plasma-d

D20969: [potd] Modernize configuration settings

filipf added a comment. Combobox popup width is still not fixed though, I have to comment on the bug report. F6804103: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraha

D20969: [potd] Modernize configuration settings

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY - port from QQC1 to QQC2 - replace ColumnLayout with Kirigami.FormLayout - make use of twinFormLayouts NOTE: On initial loadi