D21026: Fix ToolButton remaining in a pressed state after press

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:33a13d11fc55: Fix ToolButton remaining in a pressed state after press (authored by filipf). REPOSITORY R858 Qt

D21026: Fix ToolButton remaining in a pressed state after press

filipf added a comment. @mart is this okay now? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D21026: Fix ToolButton remaining in a pressed state after press

filipf added a comment. In D21026#472883 , @ngraham wrote: > Add `checkable: true` and click it Thanks! I tested it with this in a vacuum and with D21027 and it seems to be working as it should now

D21026: Fix ToolButton remaining in a pressed state after press

filipf updated this revision to Diff 58994. filipf added a comment. restore checkable state REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21026?vs=57574=58994 BRANCH no-highlight-color-after-press (branched from master)

D21026: Fix ToolButton remaining in a pressed state after press

ngraham added a comment. Add `checkable: true` and click it REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D21026: Fix ToolButton remaining in a pressed state after press

filipf added a comment. In D21026#462978 , @mart wrote: > but now it doesn't display the checked state in any way? How can I test to see the checked state is working? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D21026: Fix ToolButton remaining in a pressed state after press

mart added a comment. but now it doesn't display the checked state in any way? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH no-highlight-color-after-press (branched from master) REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham,

D21026: Fix ToolButton remaining in a pressed state after press

filipf added a comment. @mart does this look good to you? As you're the author I wouldn't want to merge without your approval. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH no-highlight-color-after-press (branched from master) REVISION DETAIL

D21026: Fix ToolButton remaining in a pressed state after press

ngraham accepted this revision. ngraham added a comment. Nice little papercut fix! REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH no-highlight-color-after-press (branched from master) REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham,

D21026: Fix ToolButton remaining in a pressed state after press

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY If you click on a QQC2 ToolButton it will remain it's pressed state, meaning it gets a background in the form of highlight color.