abetts added a comment.
+1
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D21193
To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:4b1607879f23: [Astronomical Calendar Plugin] Port to
QQC2+Kirigami Formlayout (authored by ngraham).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21193?vs=5
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.
LGTM, visually
REPOSITORY
R114 Plasma Addons
BRANCH
modernize-astronomical-calendar-plugin (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21193
To: ngraham, #vd
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
- Port to QQC2+Kirigami FormLayout style
- Use standard import names
- Adjust strings to f
