D21273: Add support for newer linux kernel power_supply API

luc4 added a comment. I don't see why, it was proposed after mine and it is already merged... Does not seem to need a review. Thanks for answering though. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: alexde,

D21273: Add support for newer linux kernel power_supply API

alexde added a comment. In D21273#586877 , @luc4 wrote: > Probably the consequence of not reviewing changes? This one can probably be abandoned. What a shame! As you are familiar with the code, you could probably review the other patch

D21273: Add support for newer linux kernel power_supply API

luc4 added a comment. Probably the consequence of not reviewing changes? This one can probably be abandoned. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n,

D21273: Add support for newer linux kernel power_supply API

alexde added a comment. This patch looks pretty similar to the already merged one https://phabricator.kde.org/D25018. How are they related? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: alexde, meven, alexeymin,

D21273: Add support for newer linux kernel power_supply API

luc4 added a comment. Ping. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D21273: Add support for newer linux kernel power_supply API

meven added a comment. Thank you @luc4 for pinging again I have tested it, it works nicely, apparently the code you are replacing has not been working for a while. The code looks good to me. F7332944: Screenshot_20190909_102057.png I

D21273: Add support for newer linux kernel power_supply API

luc4 added a comment. Ping. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21273: Add support for newer linux kernel power_supply API

meven added a comment. Friendly ping to our dear reviewers @broulik @davidedmundson @hein REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: meven, alexeymin, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2,

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

alexeymin added a comment. Hm, looks ideologically similar to how it was done in SDL2... https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson Cc: alexeymin,

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

luc4 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REPOSITORY R106 KSysguard BRANCH batt REVISION DETAIL https://phabricator.kde.org/D21273 AFFECTED FILES ksysguardd/Linux/acpi.c To: luc4 Cc: