D21336: Get PaginateModel class ready for frameworks

2019-05-23 Thread Eike Hein
hein added a comment. I wouldn't call this implementation ready for frameworks, though - it just resets all the time, which is very slow as it forces views to destroy and recreate delegates instead of just updating them. A better implementation would just (re)filter source rows

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:ccec47da6d36: Get PaginateModel class ready for frameworks (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21336?vs=58465=58476

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. nice  REPOSITORY R134 Discover Software Store BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21336 To: apol, davidedmundson Cc: davidedmundson,

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 58465. apol added a comment. More documentation REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21336?vs=58464=58465 BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21336 AFFECTED

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Some API documentation of the properties Added a d-pointer Coding style REPOSITORY R134 Discover Software Store BRANCH