D21524: Keep existing configurations' strings               

heikobecker added a comment. This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console Start

D21524: Keep existing configurations' strings               

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a9f3a3ddcb0b: Keep existing configurations strings    (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D21524: Keep existing configurations' strings               

gikari added a comment. In D21524#517780 , @apol wrote: > Do you have push powers? No, I don't have. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D21524 REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari,

D21524: Keep existing configurations' strings               

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's see how this goes. Do you have push powers? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D21524 REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari, apol,

D21524: Keep existing configurations' strings               

GB_2 added a comment. Ping. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari, apol, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21524: Keep existing configurations' strings               

gikari marked 4 inline comments as done. gikari added a comment. In D21524#506866 , @apol wrote: > Is this only necessary for gtk2? Yes. Gtk3 settings.ini custom entries remain untouchable, when settings are applied. REPOSITORY R99

D21524: Keep existing configurations' strings               

gikari updated this revision to Diff 63142. gikari added a comment. Remove redundant QString constructors and apply const modifier to QRegularExpression REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21524?vs=58987=63142 BRANCH

D21524: Keep existing configurations' strings               

apol added a comment. Is this only necessary for gtk2? INLINE COMMENTS > appearancegtk2.cpp:125 > +{ > +QRegularExpression regExp{propertyName + "=[^\n]*($|\n)"}; > const? > appearancegtk2.cpp:136 > +if (nonStringProperties.contains(propertyName)) { > +newConfigString =

D21524: Keep existing configurations' strings               

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Gtk configurator has been replacing .gtkrc-2.0 config file, with it's own settings, discarding present file contents.