D21610: Redesign Advanced tab

This revision was automatically updated to reflect the committed changes. Closed by commit R123:e020446f7019: Redesign Advanced tab (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59282=59305 REVISION

D21610: Redesign Advanced tab

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! Master only, obviously REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH redesign-sddm-advanced-tab (branched from master) REVISION DETAIL

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59282. filipf added a comment. improve string "Relogin after quit" REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59280=59282 BRANCH redesign-sddm-advanced-tab (branched from master)

D21610: Redesign Advanced tab

filipf added a comment. In D21610#475386 , @ngraham wrote: > In D21610#475385 , @filipf wrote: > > > My suggestion is to rename it to "Log in again after logging off" > > > Much better! How

D21610: Redesign Advanced tab

ngraham added a comment. In D21610#475385 , @filipf wrote: > My suggestion is to rename it to "Log in again after logging off" Much better! How about "Log in again after immediately after logging off" to emphasize how instant it is? Or

D21610: Redesign Advanced tab

filipf added a comment. In D21610#475382 , @ngraham wrote: > Much better, thanks! Works now. > > One final thing, maybe: can we re-word "Relogin after quit"? I admit I have no idea what it even does! It's also got an English error ("relogin"

D21610: Redesign Advanced tab

ngraham added a comment. Much better, thanks! Works now. One final thing, maybe: can we re-word "Relogin after quit"? I admit I have no idea what it even does! It's also got an English error ("relogin" isn't a word) and it has no tooltip to explain what it does. Needs a bit of loving.

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59280. filipf added a comment. use toggled instead of clicked REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59232=59280 BRANCH redesign-sddm-advanced-tab (branched from master)

D21610: Redesign Advanced tab

ngraham added a comment. Ah you're right, that's a pre-existing issue. However it does get worse with this redesign since the Advanced page is now much more compact. Oh well. I've found one new issue: when auto-login is enabled and you go to the Advanced page, its checkbox is checked

D21610: Redesign Advanced tab

filipf added a comment. I believe that's due to the other tab. If you try to resize the Themes tab height-wise, you'll notice the scrollbar appears when the bottom buttons start disappearing. I'll investigate some more though. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION

D21610: Redesign Advanced tab

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Nice. Looks like this layout includes some empty whitespace on the bottom though. Open it in `kcmshell` and reduce the window height: F6873598:

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59232. filipf added a comment. update comment REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59231=59232 BRANCH redesign-sddm-advanced-tab (branched from master) REVISION DETAIL

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59231. filipf added a comment. reduce height of vertical spacers REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59212=59231 BRANCH redesign-sddm-advanced-tab (branched from master)

D21610: Redesign Advanced tab

abetts added a comment. +1 on visuals REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D21610 To: filipf, ngraham, #vdg, davidedmundson Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D21610: Redesign Advanced tab

ngraham added a comment. In D21610#474842 , @filipf wrote: > The spacing between sections seems too big, I need to reduce it so that it matches the one in Kirigami's FormLayout. `QSpacerItem` works well for this, and you can customize

D21610: Redesign Advanced tab

filipf planned changes to this revision. filipf added a comment. The spacing between sections seems too big, I need to reduce it so that it matches the one in Kirigami's FormLayout. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D21610 To:

D21610: Redesign Advanced tab

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch redesigns and modernizes the Advanced tab of SDDM's KCM. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH