D21829: Improved Touch support for Kickoff

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0322d1a25fac: Improved Touch support for Kickoff (authored by steffenh, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21829: Improved Touch support for Kickoff

ngraham added a comment. Sorry this has gotten stuck in limbo, @steffenh. I discussed this with @hein and @mart and we agreed that it can go in now so that it doesn't get blocked forever, but we will need to refactor how we handle touch throughout Plasma, including here in Kickoff. To track

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 69785. steffenh edited the summary of this revision. steffenh added a comment. rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=60216=69785 BRANCH D21829 REVISION DETAIL

D21829: Improved Touch support for Kickoff

steffenh added a comment. Hi @hein. > Before we discuss alternatives: Are you willing to have me try and teach you? I'm actually going to be very busy with a move in the next few weeks, so this could end up taking quite significant time between the two of us, but if you have the time

D21829: Improved Touch support for Kickoff

hein added a comment. In D21829#498921 , @steffenh wrote: > I have the last days looking at plasma-frameworks, but my knowledge of the working of plasma is close to zero, so I am afraid I'm not able to do this. Before we discuss

D21829: Improved Touch support for Kickoff

steffenh added a comment. Oh, sorry, I have the feeling I have misunderstood the post from @hein, I have the impression he wants to make a patch to DragHelper, but if I read this again, so sorry. I have the last days looking at plasma-frameworks, but my knowledge of the working of

D21829: Improved Touch support for Kickoff

ngraham added a comment. @steffenh are you able to implement @hein's inline suggestions? I don't want this patch to get lost, it's good stuff. REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein, ngraham Cc:

D21829: Improved Touch support for Kickoff

mart added a comment. not entering in the code yet, i'm ok with it as a general UX behavior REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein, ngraham Cc: mart, sbergeron, davidedmundson, ngraham,

D21829: Improved Touch support for Kickoff

hein added a subscriber: mart. hein added a comment. I'm in principle quite OK with this minus that other patch I need to be written first to move DragHelper out into the lib (see other comment). Pitch: If you do that, it'll make it much easier to make the other menus (and other things) act

D21829: Improved Touch support for Kickoff

ngraham accepted this revision. ngraham added a comment. Works great for me. Does a #plasma person approve? REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein,

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 60216. steffenh added a comment. change variable name from tapandhold to tapAndHold REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=60018=60216 BRANCH kickoff REVISION DETAIL

D21829: Improved Touch support for Kickoff

steffenh added inline comments. INLINE COMMENTS > ngraham wrote in KickoffListView.qml:142 > Probably so click-and-hold doesn't trigger these behaviors when not using a > touchscreen. This is the Fix for Bug: 406361 In the appView the listView.currentItem will get open, but

D21829: Improved Touch support for Kickoff

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in KickoffListView.qml:142 > why do we need this? Probably so click-and-hold doesn't trigger these behaviors when not using a touchscreen. REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL

D21829: Improved Touch support for Kickoff

davidedmundson added inline comments. INLINE COMMENTS > KickoffListView.qml:142 > +if (item.appView) { > +if (mouse.source == > Qt.MouseEventSynthesizedByQt) { > +positionChanged(mouse); why do we need this? >

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 60018. steffenh added a comment. - Drag icon now follows the touch point - to make the drag icon better visible, set the drag icon size for touch drag from medium to huge and move the drag icon a bit to the top and left REPOSITORY R119 Plasma

D21829: Improved Touch support for Kickoff

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. You're becoming quite the expert on touch gestures in KDE software! :) This works great on my touchscreen, and I did not find any regressions when using my touchpad or

D21829: Improved Touch support for Kickoff

steffenh created this revision. steffenh added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. steffenh requested review of this revision. REVISION SUMMARY - enabled touch scrolling in Kickoff - open the correct category in the application tab -