D22106: [Separator] Match Breeze borders' color

bcooksley added a comment. Please note that depending on the repository. Phabricator can take anywhere from a minute or two, to update to an hour to pick up changes to a repository (it polls repositories unfortunately, and those with more frequent changes are polled more often by

D22106: [Separator] Match Breeze borders' color

filipf closed this revision. filipf added a comment. Phab hasn't picked up on the commit: https://cgit.kde.org/kirigami.git/commit/?id=9af92cc8b750b59629eeb3446108b2f8086629f7 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22106 To: filipf, #kirigami, #vdg,

D22106: [Separator] Match Breeze borders' color

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Long term, we should make this more programmatic. But since there's already a magic number in there, I think it makes sense to use a better one for the time being. REPOSITORY R169

D22106: [Separator] Match Breeze borders' color

filipf added a comment. In D22106#487287 , @mglb wrote: > Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76 > > Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing

D22106: [Separator] Match Breeze borders' color

ndavis added a comment. +1 visually, but I agree that the Breeze Widget theme should be the part that provides the theming, if possible. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22106 To: filipf, #kirigami, #vdg, ngraham Cc: ndavis, mglb, apol,

D22106: [Separator] Match Breeze borders' color

mglb added a comment. Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76 Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color. REPOSITORY R169 Kirigami REVISION DETAIL

D22106: [Separator] Match Breeze borders' color

apol added a comment. Maybe we should have the Theme provide the opacity somehow? You can look at the kde:breeze repository for the kstyle and others. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22106 To: filipf, #kirigami, #vdg, ngraham Cc: apol,

D22106: [Separator] Match Breeze borders' color

filipf added a comment. Although testing with other color schemes there is clearly an underlying difference in the code between how the Kirigami separator determines the color and Breeze: F6935969: image.png If someone could point me to the

D22106: [Separator] Match Breeze borders' color

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Kirigami separators are currently stronger than Breeze style borders used with controls. With this patch the difference