D22179: [mobile/wifi] Move network en/disable into main action

2019-07-01 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R116:3923c45e4c7b: [mobile/wifi] Move network en/disable into main action (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D22179: [mobile/wifi] Move network en/disable into main action

2019-06-30 Thread Nathaniel Graham
ngraham added a comment. I kind of feel like on mobile, the toolbar itself should just move to the bottom. No need to use a whole new paradigm of floating text-less buttons that obscure the content and don't have labels. I know this is basically copied from Android, but I don't really like

D22179: [mobile/wifi] Move network en/disable into main action

2019-06-30 Thread Nicolas Fella
nicolasfella added a comment. In D22179#488748 , @ngraham wrote: > +1 for porting to use the correct Kirigami paradigm. > > I feel like trying to do this exposes problems with our general general style (toggle-able toolbar button don't have

D22179: [mobile/wifi] Move network en/disable into main action

2019-06-30 Thread Nathaniel Graham
ngraham added a comment. +1 for porting to use the correct Kirigami paradigm. I feel like trying to do this exposes problems with our general general style (toggle-able toolbar button don't have a special appearance to indicate this) as well as the "floating text-less button" paradigm

D22179: [mobile/wifi] Move network en/disable into main action

2019-06-30 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The current switch at the top is both not