D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in logout.cpp:399-400 > Make job autodelete if not. This is no KJob REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik,

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

broulik added a comment. PowerDevil checks `if (KWorkSpace::isShuttingDown()) {` before suspending, so I think the ksmserver stuff is obsolete REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik, davidedmundson Cc:

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

davidedmundson added a comment. Given it's already broken, I would say just kill it. I've not had any related bug reports. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik, davidedmundson Cc: anthonyfieroni, sitter,

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

anthonyfieroni added inline comments. INLINE COMMENTS > logout.cpp:399-400 > } else { > -Solid::PowerManagement::stopSuppressingSleep(inhibitCookie); > +delete inhibitionJob; > +inhibitionJob = nullptr; > qCDebug(KSMSERVER) << "Client " << c->program() << "

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns added a comment. In D22296#492147 , @sitter wrote: > > So, in order to port to the API, it'd first need finishing up really. The question is - do we really want this call here, or not. As is, it is just an expensive

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

sitter added a comment. FTR: The async solid power API is not built by default as it is unfinished, it's also not API stable. I recently poked Alex Fiestas about it and he said that the parts of the new async API that actually were implemented when he handed over maintainer ship of solid

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns added a comment. After having looked into the callchain again, I am not sure what the best action here is: The old code did a DBus call of org.freedesktop.PowerManagement.Inhibit, which is implemented by powerdevil. Powerdevil only "schedules" the inhibition, but delays it for 5

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

apol added a comment. Solid::InhibitionJob isn't installed by default, is it? Is the plan to make it the public API now? Not disagreeing with the change, just would need changes in Solid first. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns created this revision. bruns added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY As KDELibs4Support pulled in a number of Frameworks, we have to explicitly