This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b159222aa558: Take in consideration flat() for the All
Applications menu (authored by tcanabrava).
CHANGED PRIOR TO
hein added a comment.
It's worth noting that this patch as-is also breaks the Dashboard UI ("All
Applications" no longer shows content), so this revert wasn't just about
implementation details but also actively broke upstream.
I'm writing an alternative patch now.
REPOSITORY
R119
tcanabrava added a comment.
@hein I'll try to follow your approach.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D22762
To: tcanabrava, davidedmundson, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel, ZrenBot, himcesjf,
davidedmundson added a comment.
m_flat currently behaves a bit specially. It doesn't affect the toplevel, it
only affects sub models created within it.
If we used AppsModel directly to fix the original bug, we would need to fix
AppsModel to follow m_flat when showing an empty
hein added a comment.
You got a point, but there's a higher-level thing with the Kicker backend in
terms of where it came from and where it's going:
- Originally it was created specifically for the Kicker menu with the backend
custom-designed to that UI. AppsModel is fairly generic
davidedmundson added a comment.
Rootmodel inherits appmodel.
Appmodel has a property flat. Therefore this does
It wasnt supported returning a non flat tree.
I do normally wait for maintainers on any new features or big changes, but
this seems like a straightforward bug fix?
hein added a comment.
FYI, as maintainer of Kicker, I've reverted this commit in master until this
review request is updated with additional info on what it's useful for. Please
don't move patches through in <15 minutes without people having a chance to
weigh in.
REPOSITORY
R119 Plasma
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b9eb1e70c96: Take in consideration flat() for the All
Applications menu (authored by tcanabrava).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
flatAllApps
REVISION DETAIL
https://phabricator.kde.org/D22762
AFFECTED FILES
