D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. Thanks, looks like it was a lot of work! It all seems to work well. Could you update the title and summary so they reflect what's in the patch now? I'll let #plasma folks take over the review now. REPOSITORY R114 Plasma

D22774: Add a button to the notes applet to clear formatting

luc4 updated this revision to Diff 63248. luc4 added a comment. I updated the TextArea element to QtQuickControls 2 (this may not be necessary) and I added a menu with a look more consistent with the rest of Plasma. The menu includes the same actions we had before: undo, redo, copy, cut,

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. Hello, I'm not a Plasma expert, but I tried to investigate the situation a bit in Qt and plasma-framework. My understanding is that the notes applet is using TextArea from QtQuick.Controls 1. TextArea 1 creates an edit menu inside Qt, probably the one defined in

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. Also notice that the current aspect doesn't look good nor consistent with the rest of Plasma. In my researches I found this: https://git.reviewboard.kde.org/r/121698/diff/1/#, which is a bit what I'm doing. I'll stop with this until an agreement is found. REPOSITORY

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. Hmm, if the existing menu is provided by Qt, changes might need to be made upstream. :/ I wonder if there's a way to inject new items into it though, without creating an entirely new one? Hopefully #plasma people should

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. I started to reimplement the menu. This is how it looked for me: F7135687: Screenshot_20190801_223211.png this is how a new menu would look like (some items and shortcuts are missing): F7135723: shot.png

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. I had a look at the code. It is my understanding the menu is provided by Qt and it is probably styled somewhere. Is this correct? I can't find a way to modify it, so I guess I'll have to create an entirely new menu. Before I go on, can someone maybe confirm if I'm on

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. I'll try to implement that behavior then. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. I'd be in favor of making the paste action always paste unformatted text, and then add a second menu item to paste with preserved formatting. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc:

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. Yes, I couldn't find a better icon so I temporarily used this. All the options you proposed are perfectly fine for me. I personally find the button sufficient but if you decide for something else I can try to update my patch. Thanks! REPOSITORY R114 Plasma

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. The use of a broom-style clear button suggests to me that it will clear everything, not just formatting. I think we either need a new/better icon, or else to give the button some explanatory text. Also, it might be helpful to take a step back and look at the

D22774: Add a button to the notes applet to clear formatting

luc4 created this revision. luc4 added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REVISION SUMMARY It frequently happens to me that formatting is preserved when pasting into the note,