D22817: Port KRunner to Plasma Components 3

broulik added a comment. > To add the clear button, maybe you can use Kirigami.SearchField instead? Not sure if that can do Plasma styling? INLINE COMMENTS > apol wrote in RunCommand.qml:56 > The button's height is by default really big and krunner then looks rather > comical. > Here

D22817: Port KRunner to Plasma Components 3

ngraham added a comment. In D22817#504049 , @ognarb wrote: > To add the clear button, maybe you can use Kirigami.SearchField instead? +1, IMO this makes more sense than manufacturing our own search field, especially since the current

D22817: Port KRunner to Plasma Components 3

apol updated this revision to Diff 62811. apol marked an inline comment as done. apol added a comment. cleanups REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22817?vs=62809=62811 BRANCH arcpatch-D22817 REVISION DETAIL

D22817: Port KRunner to Plasma Components 3

apol added inline comments. INLINE COMMENTS > broulik wrote in RunCommand.qml:56 > Why? The button's height is by default really big and krunner then looks rather comical. Here we're making sure it all stays as big as the text field after all. > broulik wrote in RunCommand.qml:226 > Why

D22817: Port KRunner to Plasma Components 3

apol updated this revision to Diff 62809. apol added a comment. Have tooltips actually shown REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22817?vs=62772=62809 BRANCH arcpatch-D22817 REVISION DETAIL https://phabricator.kde.org/D22817

D22817: Port KRunner to Plasma Components 3

ognarb added a comment. To add the clear button, maybe you can use Kirigami.SearchField instead? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22817 To: apol, #plasma, broulik Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22817: Port KRunner to Plasma Components 3

broulik added a comment. The padding on the left of the `TextField` looks off and what's up with that clear button? F7118082: Screenshot_20190730_084115.png No tooltip shows up for the configure and close buttons. INLINE COMMENTS >

D22817: Port KRunner to Plasma Components 3

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Using the new, stable components. Biggest change is that now we don't have a clear button and we need to