D22832: Fix build with pango 1.44

This revision was automatically updated to reflect the committed changes. Closed by commit R99:cf8db4ebe5ef: Fix build with pango 1.44 (authored by arojas). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22832?vs=62800=64505 REVISION DETAIL

D22832: Fix build with pango 1.44

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Just ran into the same issue today and prepared a similar patch right before getting a notification email about this! Let's do it for the stable branch for sure. REPOSITORY R99 KDE

D22832: Fix build with pango 1.44

arojas added a comment. Ping, can this go in for 5.16.5? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D22832 To: arojas, #plasma Cc: apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22832: Fix build with pango 1.44

sitter added a comment. Sure, don't take my bubbling to mean that I object to the diff. I'm just musing on it's long-term necessity When I dump the variables created by the initial PKG_CHECK_MODULES call in the finder they do have the requirements in the LIBRARIES and INCLUDES. So in

D22832: Fix build with pango 1.44

arojas added a comment. In D22832#504428 , @sitter wrote: > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic

D22832: Fix build with pango 1.44

apol added a comment. In D22832#504428 , @sitter wrote: > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic code

D22832: Fix build with pango 1.44

sitter added a comment. Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic code instead of essentially replicating the dependency information in cmake.

D22832: Fix build with pango 1.44

arojas created this revision. arojas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY pango>=1.44 headers depend on herfbuzz ones, make sure cmake can find them and pass the right