D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63458. GB_2 added a comment. Add a "Show Most Used Page" button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63404&id=63458 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63404. GB_2 added a comment. Rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63403&id=63404 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REV

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63403. GB_2 added a comment. Use Qt Labs Platform menu (need to wait until https://bugreports.qt.io/browse/QTBUG-77404 is fixed) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63338&id=63403 BRANCH por

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in SidebarMode.cpp:570 > Not a huge fan of this. > Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and > `ComboBox` popup? Not really, seems like the KQuickStyleItem only has access to the QML window of the m

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

broulik added inline comments. INLINE COMMENTS > SidebarMode.cpp:570 > emit changeToolBarItems(BaseMode::NoItems); > +} else if (watched->inherits("QWidgetWindow") && event->type() == > QEvent::MouseButtonPress) { > +QMetaObject::invokeMethod(d->quickWidget->rootObject(), "c

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63338. GB_2 added a comment. Rebase on master REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63180&id=63338 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from ma

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham added a comment. Hey, that works great! REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg, ngraham Cc: filipf, ngraham,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63180. GB_2 added a comment. Close menu when clicking anywhere in the window. Most likely not the best solution. REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=62976&id=63180 BRANCH port-system-setting

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Me too, but please wait for a #plasma person to approve or reject. :) REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. That is good enough IMO, but if anyone knows how to fix this, then please do :-) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleig

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham added a comment. Ah so it does. I think that's the most important case to cover, so tentative +1 from me. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast0

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

filipf added a comment. If it would be draining to do now, we can leave that menu at QQC1 and add a note pointing to a bug report? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. In D22896#505835 , @ngraham wrote: > Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button. It does that. Making it close when clicking anywhere wo

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham added a comment. Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: ngraham, broulik, #vdg, pla

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

broulik added a comment. "Only issue", I think that's quite a severe regression? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7141216: System Settings Sidebar QQC2 Port.png Only issue is