D22966: Wayland: backend code cleanup

2019-08-07 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:479d07200861: Wayland: backend code cleanup (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LA

D22966: Wayland: backend code cleanup

2019-08-06 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > zzag wrote in waylandconfig.h:73 > If libkscreen follows the Frameworks or the Kdelibs coding style, then > `WaylandOutput` and `*` have to be separated by a space. See source code of > Qt for more examples. > > Qt Coding Style and Frameworks Co

D22966: Wayland: backend code cleanup

2019-08-06 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > waylandconfig.h:73 > > -QMap outputMap() const; > If libkscreen follows the Frameworks or the Kdelibs coding style, then `WaylandOutput` and `*` have to be separated by a space. See source code of Qt for more examples. Qt Coding Style and

D22966: Wayland: backend code cleanup

2019-08-06 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Modernize code, make it more readable, throw away unused code. TEST PLAN Compiles, runs. REPOS