fsitter added a comment.
You think sending your minions to insult me and then disabling my account
will solve the issue? what will you do next? Disable registration so no one
points out your hypocrisy? Which overlord made the decision to disable my
account and for what?
REPOSITORY
R871
fsitter added a comment.
You think sending your minions to insult me and then disabling my account
will solve the issue? what will you do next? Disable registration so no one
points out your hypocrisy? Which overlord made the decision to disable my
account and for what? dont forgot to add
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:81c4e8f53148: Add option to discourage reporting bugs
(authored by broulik).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23261?vs=64649=64650
REVISION DETAIL
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D23261
To: broulik, #plasma, sitter
Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela,
broulik updated this revision to Diff 64649.
broulik added a comment.
- Do nothing when shutting down in non-interactive mode
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23261?vs=64647=64649
REVISION DETAIL
https://phabricator.kde.org/D23261
sitter added inline comments.
INLINE COMMENTS
> sitter wrote in main.cpp:225
> Surely it should also return right away if isShuttingDown down and
> interaction isn't allowed, otherwise you create a dump needlessly on account
> of the user not being meant to report it.
What about this?
broulik updated this revision to Diff 64647.
broulik added a comment.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
- Add i18nc
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23261?vs=64038=64647
REVISION DETAIL
sitter added inline comments.
INLINE COMMENTS
> broulik wrote in statusnotifier.cpp:144
> We never do that. Do we have a `@context` for that or should I just write
> `i18nc("Notification text", "...")`?
We do not. I always check my handy cheat sheet
broulik added inline comments.
INLINE COMMENTS
> sitter wrote in statusnotifier.cpp:144
> I care more about the context that this is a notification message than about
> the brevity recommendation.
We never do that. Do we have a `@context` for that or should I just write
`i18nc("Notification
sitter added inline comments.
INLINE COMMENTS
> broulik wrote in statusnotifier.cpp:144
> I don't think that is neccessary,
> The keep short in the buttons was mostly because back then notification
> action buttons were placed on the right side of notifications and were
> severly limited in
broulik added a comment.
> Whatever happened to m_iconName?
It did a
`KService::serviceByStorageId(crashedApp->fakeExecutableBaseName());` lookup,
e.g. for "dolphin" and doesn't find "org.kde.dolphin". So this stopped working
at some point without anyone caring.
INLINE COMMENTS
>
sitter added a comment.
Whatever happened to m_iconName?
Code looks sound.
INLINE COMMENTS
> main.cpp:225
> +// For automatically restarted services, do nothing in case no
> interaction is allowed
> +if (!forceDialog && !interactionAllowed && restarted) {
> +return 0;
davidedmundson added a comment.
Makes sense to me.
There are situations with no useful backtraces and users can't install them,
but it's nice to have some feedback than just a window completely disappearing.
++
REPOSITORY
R871 DrKonqi
REVISION DETAIL
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This is for vendors and environments that don't want to allow their users to
report bugs
14 matches
Mail list logo
