davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in taskmanager.cpp:99
> This role is a `QIcon`, potentially created from the window pixmap in case
> window mapping failed.
> Or is that what the "tiny mods in ProcessModel" is about?
Yeah, and I need to map it to there
davidedmundson updated this revision to Diff 64410.
davidedmundson added a comment.
update
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23356?vs=64326=64410
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23356
AFFECTED FILES
hein added a comment.
Do you really need a TasksModel, or is a WindowTasksModel enough?
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D23356
To: davidedmundson, #plasma
Cc: hein, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2,
broulik added inline comments.
INLINE COMMENTS
> taskmanager.cpp:23
> +
> +#include
> +#include
Unused
> taskmanager.cpp:58
> +const QModelIndex index = m_model->index(i, 0, QModelIndex());
> +if
> (!index.data(TaskManager::AbstractTasksModel::IsWindow).toBool()) {
>
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Currently this is all hardcoded in ProcessModel. By moving it into a
