D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

davidedmundson added a comment. belated +1 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag, romangg Cc: davidedmundson, ngraham, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

ngraham added a comment. Thanks so much for the patch, Jason! Feel free to keep on submitting more if you encounter any further issues. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag, romangg Cc: ngraham, romangg,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

This revision was automatically updated to reflect the committed changes. Closed by commit R133:90add6922411: Do not allow the greeter to send the same password multiple times (Fix GPG… (authored by jfranklin, committed by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534169 , @ngraham wrote: > +1. Do you wanna commit this, or should I? Are you referring to me? I assume not, just making sure... > @jfranklin can we use `Jason Franklin ` as your email address

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

ngraham added a comment. +1. Do you wanna commit this, or should I? @jfranklin can we use `Jason Franklin ` as your email address for the git authorship information? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534154 , @romangg wrote: > Or let's just get it in. It's a small change and we still have the beta phase to test it. Fantastic. Yep, sooner is better in our case. REPOSITORY R133 KScreenLocker

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Or let's just get it in. It's a small change and we still have the beta phase to test it. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To:

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

romangg added a comment. Ok, you need this for 5.17? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc: romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534126 , @romangg wrote: > Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me.

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. In D23849#534126 , @romangg wrote: > Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me.

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

romangg added a comment. Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#532568 , @zzag wrote: > @jfranklin Ping me if you don't get any feedback in a day or two. Hey there @zzag, haven't seen any activity here. Just pinging you per your request. Thanks! REPOSITORY

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. @jfranklin Ping me if you don't get any feedback in a day or two. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. This change looks good to me, however I know only general bits of KScreenLocker. Perhaps someone else from #KWin or #Plasma could review this patch. REPOSITORY R133 KScreenLocker

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. Friendly ping concerning this issue. Has anyone related to the screen locker project had some time to take a quick look at this? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc:

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. I also didn't point this out in my original post, but I fixed a misuse of `pam_end()`. The status passed to `pam_end()` should be the returned status of the last PAM library call. This is noted in the documentation for Linux-PAM. REPOSITORY R133 KScreenLocker

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin created this revision. jfranklin added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jfranklin requested review of this revision. REVISION SUMMARY Greetings, I am working on improving some of the functionality in the screen