D24068: docs: add contributing guide

davidedmundson added a comment. > Since there is no other one at the moment I don't see the need to ask again You could at least follow up the replies. It was even met with a positive response, with some effort this could easily become a thing. It's a completely different story to

D24068: docs: add contributing guide

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:50cf930ec824: docs: add contributing guide (authored by romangg). CHANGED PRIOR TO COMMIT

D24068: docs: add contributing guide

romangg added a comment. In D24068#558809 , @mart wrote: > Overall most of those are sensible policies (and would really make sense globally in plasma, rather than a specific subproject) > I feel the Conventional Commit policy to rise the

D24068: docs: add contributing guide

mart added a comment. Overall most of those are sensible policies (and would really make sense globally in plasma, rather than a specific subproject) I feel the Conventional Commit policy to rise the barrier of entry a tad too much tough (and not sure i would really want it in the resto of

D24068: docs: add contributing guide

romangg added a comment. In D24068#558466 , @davidedmundson wrote: > README is really good. > > Did you email kde-devel about this commit policy? I thought you did, but I can't find it. > As someone who regularly commits across many

D24068: docs: add contributing guide

davidedmundson added a comment. README is really good. Did you email kde-devel about this commit policy? I thought you did, but I can't find it. As someone who regularly commits across many many repos if every maintainer enforced their own thing I would really struggle. INLINE

D24068: docs: add contributing guide

romangg updated this revision to Diff 69020. romangg added a comment. Fix typo REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=68918=69020 BRANCH contributing-guide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED FILES

D24068: docs: add contributing guide

romangg updated this revision to Diff 68918. romangg added a comment. Add a minimal readme file REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=68917=68918 BRANCH contributing-guide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED

D24068: docs: add contributing guide

romangg updated this revision to Diff 68917. romangg added a comment. Remove scopes common and console. Small areas, do not warrant scope on themselves. If there is a change to one of them just don't use the optional scope. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D24068: docs: add contributing guide

romangg added inline comments. INLINE COMMENTS > yurchor wrote in CONTRIBUTING.md:58 > Typo: "communication" (singular) or "happen" Thanks! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24068 To: romangg, #plasma Cc: yurchor, broulik, ngraham, plasma-devel,

D24068: docs: add contributing guide

romangg updated this revision to Diff 68445. romangg marked an inline comment as done. romangg added a comment. - Rebase - Fix typo REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66437=68445 BRANCH contributingGuide REVISION DETAIL

D24068: docs: add contributing guide

yurchor added a comment. Thanks in advance for fixing this minor typo. INLINE COMMENTS > CONTRIBUTING.md:58 > +## Contact > +Real-time communications about the project happens on the IRC channel > `#plasma` on freenode and the bridged Matrix room `#plasma:kde.org`. > + Typo:

D24068: docs: add contributing guide

romangg added a comment. In D24068#534383 , @broulik wrote: > > The CHANGELOG keyword is cumbersome to use because the summary line most often already tells sufficiently what the commit is about. So it would only be a repetition of what is

D24068: docs: add contributing guide

romangg updated this revision to Diff 66437. romangg added a comment. - Explain types REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66424=66437 BRANCH contributingGuide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED FILES

D24068: docs: add contributing guide

broulik added a comment. > The CHANGELOG keyword is cumbersome to use because the summary line most often already tells sufficiently what the commit is about. So it would only be a repetition of what is already written. Besides why should we want to have a disparity between changelog and

D24068: docs: add contributing guide

romangg added a comment. In D24068#534288 , @ngraham wrote: > In terms of changelogs, you can already use the FEATURE: and CHANGELOG: tags in your commit message. That's already there and similarly we're not actually using it. Might it make

D24068: docs: add contributing guide

ngraham added a comment. In terms of changelogs, you can already use the FEATURE: and CHANGELOG: tags in your commit message. That's already there and similarly we're not actually using it. Might it make sense to develop better documentation around using those throughout all of KDE?

D24068: docs: add contributing guide

romangg added a comment. In D24068#534280 , @ngraham wrote: > Is this Conventional Commits spec something we think we want to use elsewhere? I'm sure I can get used to it, but the prefix thing seems kind of rigid and I'm wondering what it

D24068: docs: add contributing guide

ngraham added a comment. Is this Conventional Commits spec something we think we want to use elsewhere? I'm sure I can get used to it, but the prefix thing seems kind of rigid and I'm wondering what it really adds other than a bunch of process that will need to be explained over and over

D24068: docs: add contributing guide

romangg updated this revision to Diff 66424. romangg added a comment. - Grammar fix REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66422=66424 BRANCH contributingGuide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED FILES

D24068: docs: add contributing guide

romangg updated this revision to Diff 66422. romangg added a comment. - Add period - Change or to and REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=66421=66422 BRANCH contributingGuide REVISION DETAIL https://phabricator.kde.org/D24068

D24068: docs: add contributing guide

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This adds a document providing information on how to contribute to KScreen. It includes