D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. I see. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jen

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561773 , @ngraham wrote: > Conceptually it seems like there are two ways to go: > > - Have a single Breeze theme that always follows the color scheme > - Expose the ability to force the use of a particular c

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Conceptually it seems like there are two ways to go: - Have a single Breeze theme that always follows the color scheme - Expose the ability to force the use of a particular color scheme via some UI (for example adding "Breeze Dark" and "Breeze Light" themes that

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561761 , @ngraham wrote: > Could we repurpose the Breeze Light and Breeze Dark GTK themes to simply hardcode everything to be dark or light rather than following the color scheme? That mirrors what we do for the

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Could we repurpose the Breeze Light and Breeze Dark GTK themes to simply hardcode everything to be dark or light rather than following the color scheme? That mirrors what we do for the Plasma theme. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricat

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561739 , @ngraham wrote: > I thought this patch results in a "Breeze light" theme becoming visible in the KCM. If so, that would seem to fulfill the request, unless I'm misunderstanding how the Breeze Dark and p

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. I thought this patch results in a "Breeze light" theme becoming visible in the KCM. If so, that would seem to fulfill the request, unless I'm misunderstanding how the Breeze Dark and proposed Breeze Light themes work. If these themes don't have hardcoded colors (as o

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561710 , @ngraham wrote: > We got another bug report illustrating another reason why this might be desirable from a user perspective, aside from the Chromium bug: https://bugs.kde.org/show_bug.cgi?id=413111 >

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. We got another bug report illustrating another reason why this might be desirable from a user perspective, aside from the Chromium bug: https://bugs.kde.org/show_bug.cgi?id=413111 I'll rescind my objection so we can review and get it in. Can you rebase the patch

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. Filed a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1006573 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, r

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Yeah, please do file a bug on Chromium. I'm hesitant to approve this because once we create a "Breeze Light" GTK theme, will we actually be able to remove it? Also, is the number of people who know that you'll need to use this new GTK theme to solve that specific

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#535494 , @ngraham wrote: > (BTW It would be nice if that information were spelled out clearly in the Test Plan section :) ) > > Oh, gross. Better than nothing I guess, if it's impossible to fix the bug any o

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. (BTW It would be nice if that information were spelled out clearly in the Test Plan section :) ) Oh, gross. Better than nothing I guess, if it's impossible to fix the bug any other way. On the other hand, this feels like it kind of partially defeats the point of

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#535486 , @ngraham wrote: > Window decoration buttions in Chromium with CSDs and the Breeze Light color scheme don't show any difference with the patch applied and deployed. This isn't elegant, but it's be

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Window decoration buttions in Chromium with CSDs and the Breeze Light color scheme don't show any difference with the patch applied and deployed. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, pl

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#535474 , @ngraham wrote: > Hmm, this doesn't seem to work for me. Could you elaborate? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraha

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Hmm, this doesn't seem to work for me. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesj

D24122: [GTK3] Generate Breeze Light assets

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Breeze Light assets are now generated to allow bypassing a bug with Chromium where recolorable icons