D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538988 , @ngraham wrote: > Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538988 , @ngraham wrote: > Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port

D24161: Make KCM look more like applet

ngraham added a comment. Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port devices, show the port chooser combobox instead of the name of the current port, in both

D24161: Make KCM look more like applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:608e9e6fe793: Make KCM look more like applet (authored by sefaeyeoglu, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66945. sefaeyeoglu added a comment. Align mute button centered with slider REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66943=66945 BRANCH feat-applet-ux REVISION DETAIL

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66943. sefaeyeoglu added a comment. Fix wrong display name of default-device button REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66920=66943 BRANCH feat-applet-ux REVISION DETAIL

D24161: Make KCM look more like applet

GB_2 added a comment. I'd also align the mute button with the slider, like in the applet. INLINE COMMENTS > DeviceListItem.qml:89 > +Button { > +text: i18n("Default device") > +icon.name: "favorite" "Default Device" REPOSITORY R115

D24161: Make KCM look more like applet

GB_2 added inline comments. INLINE COMMENTS > sefaeyeoglu wrote in MuteButton.qml:32 > I feel like QQC2 tooltips look out of place. They don't have the same shadow > as //normal// tooltips and do not fade in That is something that needs to be fixed in the QQC2 desktop style, so it is

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538429 , @ngraham wrote: > I love it, and the code changes look sane to me. > > #plasma folks or @drosca, any objections? Glad you like it  Looks like

D24161: Make KCM look more like applet

ngraham accepted this revision. ngraham added a subscriber: drosca. ngraham added a comment. This revision is now accepted and ready to land. I love it, and the code changes look sane to me. #plasma folks or @drosca, any objections? REPOSITORY

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66920. sefaeyeoglu edited the test plan for this revision. sefaeyeoglu added a comment. Make icon full height for playback devices, too REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24161: Make KCM look more like applet

sefaeyeoglu marked 2 inline comments as done. sefaeyeoglu added a comment. Right! I completely forgot about that. Will work on it REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24161 To: sefaeyeoglu, #plasma, #vdg Cc: ngraham, davidedmundson,

D24161: Make KCM look more like applet

ngraham added a comment. Nice. Now that I compare the two, one remaining difference is that each item's icon differs in location in the applet vs the KCM. In the Applet, it's larger and to the left of everything else; whereas in the KCM the icon is small and in the same row as the

D24161: Make KCM look more like applet

sefaeyeoglu marked 2 inline comments as done. sefaeyeoglu added inline comments. INLINE COMMENTS > ngraham wrote in VolumeSlider.qml:44 > Hmm, I don't like how this makes tickmarks appear. If you need to round the > value, you can do that in `onMoved: { blabla; }`, or just round the value of >

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66917. sefaeyeoglu added a comment. Remove stepping again, change label text of port selection REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66909=66917 BRANCH feat-applet-ux

D24161: Make KCM look more like applet

ngraham added inline comments. INLINE COMMENTS > DeviceListItem.qml:54 > +visible: portbox.count > 1 > +text: i18nd("kcm_pulseaudio", "Port") > +} While we're at it, let's also make this say "Port:" > VolumeSlider.qml:44 > to: PulseAudio.MaximalVolume >

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66909. sefaeyeoglu edited the test plan for this revision. sefaeyeoglu added a comment. Remove redundant whitespace from copyright header REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66908. sefaeyeoglu added a comment. Use QQC2 ToolButton instead of Button for Mute. Add stepping to volume slider, similar to applet. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24161: Make KCM look more like applet

ngraham added inline comments. INLINE COMMENTS > MuteButton.qml:26 > > -Button { > +QQC2.Button { > property bool muted: true Now that this thing is moved next to the volume slider, I feel like it should be a ToolButton, like in the applet. REPOSITORY R115 Plasma Audio Volume Applet

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66783. sefaeyeoglu added a comment. Import QtQuick.Controls as QQC2 and fix ToolTip delay REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=9=66783 BRANCH feat-applet-ux REVISION

D24161: Make KCM look more like applet

sefaeyeoglu added inline comments. INLINE COMMENTS > ngraham wrote in Applications.qml:49 > I don't think the addition of the word "Streams" adds useful information here. The applet already says Streams here. > ngraham wrote in MuteButton.qml:32 > Using the attached `ToolTip` property is just

D24161: Make KCM look more like applet

ngraham added inline comments. INLINE COMMENTS > Applications.qml:49 > enabled: eventStreamView.count || sinkInputView.count > -text: i18nd("kcm_pulseaudio", "Playback") > +text: i18nd("kcm_pulseaudio", "Playback Streams") > disabledText:

D24161: Make KCM look more like applet

sefaeyeoglu added inline comments. INLINE COMMENTS > MuteButton.qml:32 > +ToolTip.visible: hovered > +ToolTip.text: i18ndc("kcm_pulseaudio", "Mute audio stream", "Mute %1", > inputText.text) // a little hacky > checkable: true I actually think this is the wrong way of doing

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 9. sefaeyeoglu added a comment. Set domain for all i18n strings REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=7=9 BRANCH feat-applet-ux REVISION DETAIL

D24161: Make KCM look more like applet

davidedmundson added inline comments. INLINE COMMENTS > Applications.qml:87 > enabled: sourceOutputView.count > 0 > -text: i18nd("kcm_pulseaudio", "Recording") > disabledText: i18ndc("kcm_pulseaudio", "@label", "No > Applications Recording Audio") please

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#536408 , @GB_2 wrote: > Please add reviewers and subscribers next time. Sorry. I didn't know who I should add so I just added #VDG as subscriber. REPOSITORY

D24161: Make KCM look more like applet

sefaeyeoglu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY I was looking through changes in plasma-pa and noticed, that the KCM looks very different in contrast to the applet. TEST