D24224: Start of the accessibility KCM

tcanabrava added a comment. After squashing the commits to remove the broken history, arc diff opened a new revision. https://phabricator.kde.org/D25375 INLINE COMMENTS > ervin wrote in kcmaccessibilitymouse.kcfg:34 > Wouldn't an Enum be more suited here? This i a spinBox with a range

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69945. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

ngraham added a comment. So... fix it? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava, ngraham, bport, ervin Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#561693 , @ngraham wrote: > It doesn't compile: > > /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory > 1 |

D24224: Start of the accessibility KCM

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. A few changes still needed. Also, in all the QML code we need to handle immutability of the settings (unfortunately that part can't be easily made magic like for the widgets).

D24224: Start of the accessibility KCM

ngraham added a comment. It doesn't compile: /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory 1 | #include "kns3/downloaddialog.h" | ^~~ Also we should

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69651. tcanabrava added a comment. - Fix Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=69650=69651 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED FILES

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7759258: image.png INLINE COMMENTS > bport wrote in CMakeLists.txt:24 > Not sure why we have this change in this code review, seems unrelated completely unrelated, thanks for spotting. REPOSITORY R119 Plasma Desktop

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69650. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

ngraham added a comment. In D24224#547897 , @tcanabrava wrote: > F7605185: kcm_access.png Lists such as these always need frames and backgrounds, like how it looks in the Notifications KCM. Just

D24224: Start of the accessibility KCM

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmaccess.cpp:171 > + > +m_mouseSettings = new MouseSettings(); > +m_keyboardSettings = new KeyboardSettings(); new MouseSettings(this) in order to

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7605185: kcm_access.png Now it uses a Vertical List, providing a better navigation mode, The Settings where also rewritten using KConfigXT so I don't need to deal with all the possible properties. This actually hit a hard

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 68019. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24224: Start of the accessibility KCM

tcanabrava added inline comments. INLINE COMMENTS > bport wrote in kcmaccess.h:32-67 > Using KConfigXT will remove lots of boilerplate code (tons of property > declaration + associated methods and easiest, load, save and defaults method). > And with the work done by @ervin on KConfigXT and

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#545013 , @broulik wrote: > Can you please follow KDE Frameworks coding style Sorry, it was by mistake. I'll fix the style. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24224: Start of the accessibility KCM

broulik added a comment. Can you please follow KDE Frameworks coding style REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava, ngraham Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24224: Start of the accessibility KCM

bport added subscribers: ervin, bport. bport added inline comments. INLINE COMMENTS > kcmaccess.h:32-67 > +Q_PROPERTY(int timeoutDelay READ timeoutDelay > WRITE setTimeoutDelayNOTIFY timeoutDelayChanged) > +Q_PROPERTY(int bounceKeysDelay READ

D24224: Start of the accessibility KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Why is `kcms/colors/CMakeLists.txt` being changed? Looks unrelated. As a general UI principle, whenever you have a group of controls that's mostly checkboxes, don't use

D24224: Start of the accessibility KCM

tcanabrava added a comment. this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava Cc:

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 67571. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D24224: Start of the accessibility KCM

mart added inline comments. INLINE COMMENTS > Bell.qml:27 > + > +ColumnLayout { > +QQC2.GroupBox { Shouldn't use groupboxes at all, but just FormLayouts with sections Kirigami.FormLayout { Item{ Kirigami.formData.title: i18n("Audible Bell")

D24224: Start of the accessibility KCM

ngraham added a comment. Don't change `kcm_access` to `kcmaccess` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava Cc: ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D24224: Start of the accessibility KCM

mart added a comment. Visually, it looks exactly like the old one, but in qml.. which gives it several layouting problems Since is tabbed (vdg should be contacted tough to see if they don't have a different option other than tabbed) it should use https://phabricator.kde.org/D23835 (which

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#537680 , @whiting wrote: > Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard

D24224: Start of the accessibility KCM

whiting added a comment. Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures)

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66834. tcanabrava added a comment. - Make buttons work REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=66831=66834 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED

D24224: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is a 1 - 1 translation of the QWidgets version of the Accessibility KCM - Most of the functionality is there, and the