D24392: Turn the config into the single source of truth

2019-10-04 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c694f9752f3: Turn the config into the single source of truth (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24392?vs=67302=67306

D24392: Turn the config into the single source of truth

2019-10-04 Thread Kevin Ottens
ervin updated this revision to Diff 67302. ervin added a comment. Add missing copyright header change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24392?vs=67268=67302 REVISION DETAIL https://phabricator.kde.org/D24392 AFFECTED FILES

D24392: Turn the config into the single source of truth

2019-10-03 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. I investigated a bit where m_defaultTheme comes from. It seems it goes all way back to the old plasma4 version of the kcm, where Theme was a singleton. now there is no need whatsoever for

D24392: Turn the config into the single source of truth

2019-10-03 Thread Kevin Ottens
ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY The module had a somewhat convoluted logic around the management of its settings. Sometimes it