This revision was automatically updated to reflect the committed changes.
ahiemstra marked an inline comment as done.
Closed by commit R169:4479e865be45: Properly check enabled state of Action for
ActionToolBar buttons (authored by ahiemstra).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST
ahiemstra updated this revision to Diff 67543.
ahiemstra added a comment.
- Do not implicitly convert float to bool
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24498?vs=67501=67543
BRANCH
actiontoolbar_enable
REVISION DETAIL
ahiemstra marked an inline comment as done.
ahiemstra added inline comments.
INLINE COMMENTS
> apol wrote in ActionToolBar.qml:126
> I'd do the enabled && opacity, it feels very wrong using a real number as a
> boolean >.<.
Agreed. I made the opacity check more explicit.
REPOSITORY
R169
apol added a comment.
+1 otherwise
INLINE COMMENTS
> ActionToolBar.qml:126
> opacity: x + width <= parent.width
> -enabled: opacity
> +enabled: opacity && modelData.enabled
>
I'd do the enabled && opacity, it feels very wrong
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
The opacity binding overrides PrivateActionToolButton's enabled binding,
which means
