This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0115ad12b25a: Do not warn about LayoutDirection in
SearchField (authored by ahiemstra).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24499?vs=67541=67553
ognarb accepted this revision.
ognarb added a comment.
Thanks
REPOSITORY
R169 Kirigami
BRANCH
searchfield_nowarning
REVISION DETAIL
https://phabricator.kde.org/D24499
To: ahiemstra, #kirigami, broulik, ognarb
Cc: ognarb, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,
ahiemstra updated this revision to Diff 67541.
ahiemstra added a comment.
- Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24499?vs=67502=67541
BRANCH
searchfield_nowarning
REVISION
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Can you also fix the icon name? :) The "rtl" in the icon name refers to the
direction of the icon (pointing from right to left), not for RTL languages. It
must be "ltr" for
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
LayoutDirection can only be used on visual items, Action is not one of
those. So we
