D24503: Integrate the normal keyboard layout switcher

davidedmundson added a comment. > I'd say so. We can do it when we deprecate the SNI though, unless you really want it now. I've never done it so I'll have to research how it's done. I don't want it to get forgotten and us to do work in a rush when the release comes along. ---

D24503: Integrate the normal keyboard layout switcher

apol added a comment. > Can that work be resumed/used? See D14796 . It seems like the original author is MIA. I rebased the patch, seems to work but adopting it will set us back as the ibus backend was never implemented. REPOSITORY R119 Plasma

D24503: Integrate the normal keyboard layout switcher

mart added a comment. In D24503#545961 , @hein wrote: > For context though, in the GSoC the following work was done: > > - The keyboard layout KCM was rewritten in Qt Quick Can that work be resumed/used? REPOSITORY R119 Plasma

D24503: Integrate the normal keyboard layout switcher

apol added a comment. This got landed by arc together with another patch. I didn't mean to land it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24503: Integrate the normal keyboard layout switcher

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f2e579f9b366: Integrate the normal keyboard layout switcher (authored by apol). REPOSITORY R119 Plasma Desktop

D24503: Integrate the normal keyboard layout switcher

apol added a comment. I don't claim to solve the whole problem, it's just a step forward. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24503: Integrate the normal keyboard layout switcher

hein added a comment. It's a small part of the work Geon Park did in his GSoC project to refactor kimpanel and our input sources management in general, but in a more merge-friendly format. The former sadly never got any review attention because the patch was too big, so maybe this is

D24503: Integrate the normal keyboard layout switcher

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in layout.js:38 > Do we also need a plasma upgrade script if we remove the SNI from kded/kwin I'd say so. We can do it when we deprecate the SNI though, unless you really want it now. I've never done it so I'll have to research

D24503: Integrate the normal keyboard layout switcher

broulik added a comment. Do we need an update script to add this plasmoid to all existing setups? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24503: Integrate the normal keyboard layout switcher

davidedmundson added a comment. Makes sense, there's a lot of red and it's about to lead to more. I like that. INLINE COMMENTS > main.qml:45-47 > width: parent.width > height: parent.height > +anchors.centerIn: parent anchors.fill > layout.js:38 > - > -/*

D24503: Integrate the normal keyboard layout switcher

apol updated this revision to Diff 67514. apol added a comment. Send a sensible font size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24503?vs=67513=67514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24503 AFFECTED FILES

D24503: Integrate the normal keyboard layout switcher

apol updated this revision to Diff 67513. apol added a comment. Remove unused function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24503?vs=67512=67513 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24503 AFFECTED FILES

D24503: Integrate the normal keyboard layout switcher

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This deprecates the SNI from KWin in favour of this plasmoid that will allow doing the same as well as