D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka added a comment. In D24530#547085 , @ngraham wrote: > FWIW since you landed this on master rather than `Plasma/5.17`, it will only be in Plasma 5.18, not 5.17.1. > > At this point, if it's critical to go into 5.17.1, you should

D24530: [XembedSNIProxy] If available, always use 32-bit color.

ngraham added a comment. FWIW since you landed this on master rather than `Plasma/5.17`, it will only be in Plasma 5.18, not 5.17.1. At this point, if it's critical to go into 5.17.1, you should cherry-pick the commit onto the `Plasma/5.17` branch since landing it there and merging

D24530: [XembedSNIProxy] If available, always use 32-bit color.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e934611316b: [XembedSNIProxy] If available, always use 32-bit color. (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24530: [XembedSNIProxy] If available, always use 32-bit color.

davidedmundson added a comment. You can merge now :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24530: [XembedSNIProxy] If available, always use 32-bit color.

mlaurent added a comment. Hi, You can't commit yet as nobody accepted this patch. Regards REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: mlaurent, plasma-devel, LeGast00n,

D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka added a comment. I have Develop Account now. Is review finished or something more is needed? Can I push this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: plasma-devel,

D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka added a comment. D24514 is merged, this one should apply smoothly now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: plasma-devel,

D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka created this revision. kmaterka added reviewers: davidedmundson, Plasma: Workspaces, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY If available, always use 32-bit color. We don't need

D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka added a comment. Needs to be applied after D24514 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,