D24653: discover: check package status before trying to install/update it

2019-10-15 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:dd9ba961d7e9: discover: check package status before trying to install/update it (authored by alnikiforov, committed by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24653: discover: check package status before trying to install/update it

2019-10-15 Thread Aleksei Nikiforov
alnikiforov added a comment. In D24653#547385 , @apol wrote: > Please submit to master. I've updated patch and removed additional parenthesis in condition. But I don't see how I can submit this change to repository, I probably don't have

D24653: discover: check package status before trying to install/update it

2019-10-15 Thread Aleksei Nikiforov
alnikiforov updated this revision to Diff 67961. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24653?vs=67941=67961 REVISION DETAIL https://phabricator.kde.org/D24653 AFFECTED FILES

D24653: discover: check package status before trying to install/update it

2019-10-15 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Please submit to master. INLINE COMMENTS > PackageKitBackend.cpp:586 > > +if ((info == PackageKit::Transaction::InfoRemoving) || (info == > PackageKit::Transaction::InfoObsoleting)) { >

D24653: discover: check package status before trying to install/update it

2019-10-15 Thread Aleksei Nikiforov
alnikiforov created this revision. alnikiforov added reviewers: jriddell, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY With latest changes to packagekit, it may now return more packages from