ngraham added a comment.
I had a feeling this would be popular. :)
REPOSITORY
R134 Discover Software Store
BRANCH
revert-sticky-notifications (branched from Plasma/5.17)
REVISION DETAIL
https://phabricator.kde.org/D24766
To: ngraham, apol, broulik, #discover_software_store
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d9db05ddef96: Revert change to make the notification
persistent (authored by ngraham).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
revert-sticky-notifications (branched from Plasma/5.17)
REVISION DETAIL
https://phabricator.kde.org/D24766
To: ngraham, apol, broulik,
ngraham updated this revision to Diff 68265.
ngraham marked an inline comment as done.
ngraham added a comment.
Don't stop keeping track of the notification, so we can still close it when
Discover is launched
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
ngraham added a comment.
That pares down the diff quite a bit. :)
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D24766
To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev,
apol added a comment.
Other than that, LGTM
INLINE COMMENTS
> DiscoverNotifier.cpp:67
> KRun::runCommand(QStringLiteral("plasma-discover"), nullptr);
> -if (m_updatesAvailableNotification) {
> m_updatesAvailableNotification->close(); }
> }
I wouldn't remove these. It's good that
ognarb added a comment.
+1
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D24766
To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen,
nicolasfella added a comment.
Yes please!
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D24766
To: ngraham, apol, broulik, #discover_software_store
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen,
ngraham created this revision.
ngraham added reviewers: apol, broulik, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Nobody liked it and it was annoying. From a conceptual standpoint,
