This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f9a664cfd898: Only show "Unlock Widgets" in the
UI, not "Lock Widgets" (authored by GB_2).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24839?vs=68510&id
ngraham accepted this revision.
ngraham added a comment.
This will unclutter the context menu a bit, +1
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D24839
REVISION DETAIL
https://phabricator.kde.org/D24839
To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, p
GB_2 added a comment.
Ping.
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D24839
REVISION DETAIL
https://phabricator.kde.org/D24839
To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2 updated this revision to Diff 68510.
GB_2 added a comment.
Avoid negating entire boolean statements
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24839?vs=68480&id=68510
BRANCH
arcpatch-D24839
REVISION DETAIL
https://phabricator.kde.org
broulik added inline comments.
INLINE COMMENTS
> menu.cpp:146
> +// Only show "Unlock Widgets" in the UI, not "Lock Widgets"
> +if (!(name == QLatin1String("lock widgets") &&
> c->corona()->immutability() == Plasma::Types::Mutable)) {
> +action
GB_2 updated this revision to Diff 68480.
GB_2 added a comment.
Rebase
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24839?vs=68468&id=68480
BRANCH
arcpatch-D24839
REVISION DETAIL
https://phabricator.kde.org/D24839
AFFECTED FILES
containm
ngraham added a comment.
Also needs a rebase
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24839
To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himc
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.
REVISION SUMMARY
Not needed for normal users with the new edit mode system.
TEST PLAN
Lock the widgets before compili
