D24853: [DigitalClock] Fix layout and QML warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:82cfabd0a5c8: [DigitalClock] Fix layout and QML warnings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68743=68745

D24853: [DigitalClock] Fix layout and QML warnings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24853 To: kmaterka, #plasma, #plasma_workspaces, ngraham Cc: ngraham,

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka updated this revision to Diff 68743. kmaterka added a comment. Remove hardcoded margins, these are not needed anymore. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68524=68743 BRANCH master REVISION DETAIL

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in configTimeZones.qml:58 > Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing` I just copied values form the original Rectangle. I will remove it entirely, probably it's not needed anymore. REPOSITORY

D24853: [DigitalClock] Fix layout and QML warnings

ngraham added a comment. Fair enough, that seems reasonable. INLINE COMMENTS > configTimeZones.qml:58 > +Layout.fillWidth: true > +Layout.margins: 1 > Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing` REPOSITORY R120 Plasma Workspace REVISION

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka added a comment. It looks like there are some review changes required in D24798 . Maybe I can commit my changes first? D24798 needs changes anyway and it would be good to split QCC1 -> QCC2 migration from

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka marked 3 inline comments as done. kmaterka added a comment. In D24853#552228 , @ngraham wrote: > Some of this partially conflicts with D24798 FWIW. I can wait and rebase later - your

D24853: [DigitalClock] Fix layout and QML warnings

ngraham added a comment. Some of this partially conflicts with D24798 FWIW. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24853 To: kmaterka, #plasma, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel,

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka updated this revision to Diff 68524. kmaterka marked 3 inline comments as done. kmaterka added a comment. Review changes: Kirigami component, removed anchors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68512=68524 BRANCH

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka marked 3 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in configTimeZones.qml:32 > Do you need these? > > Generally it's a sign of a problem or bad layering if the root item has > anchors in it. Ops, copy from HolidayConfig.qml. I'll

D24853: [DigitalClock] Fix layout and QML warnings

davidedmundson added a comment. Concept +1, I love layouts INLINE COMMENTS > configTimeZones.qml:32 > id: timeZonesPage > -width: parent.width > -height: parent.height > +anchors.left: parent.left > +anchors.right: parent.right Do you need these? Generally it's a sign

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Fixed issue when time zone configuration page was not scaling corrently. As a result two srollbars were rendered. Fixed few