This revision was automatically updated to reflect the committed changes.
kmaterka marked an inline comment as done.
Closed by commit R885:2481a8eb6a22: Fix size of SpinBoxes (authored by
kmaterka).
REPOSITORY
R885 Redshift Control for Plasma
CHANGES SINCE LAST UPDATE
kmaterka marked an inline comment as done.
kmaterka added inline comments.
INLINE COMMENTS
> ngraham wrote in ConfigGeneral.qml:64
> Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4`
OK, I made it the same width as IconPicker, it should look nice
REPOSITORY
R885
kmaterka updated this revision to Diff 68558.
kmaterka added a comment.
Do not use hardcoded values
REPOSITORY
R885 Redshift Control for Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24861?vs=68529=68558
BRANCH
master
REVISION DETAIL
ngraham added inline comments.
INLINE COMMENTS
> ConfigGeneral.qml:64
> id: manualTemperatureStep
> +Layout.minimumWidth: 80
> decimals: 0
Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4`
REPOSITORY
R885 Redshift Control for
kmaterka created this revision.
kmaterka added reviewers: martinkostolny, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.
REVISION SUMMARY
The numbers in the text entry box for "Manual Brightness Step" in the