D24879: [ComboBox] Follow focusPolicy

This revision was automatically updated to reflect the committed changes. Closed by commit R858:b1452c37b49c: [ComboBox] Follow focusPolicy (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24879?vs=68586=69256#toc REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D24879: [ComboBox] Follow focusPolicy

mart added a comment. one thing that may be tried is to use input handlers instead of the mousearea to manage the wheel (tough i am not sure we can already use them in frameworks due to qt version requirements) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D24879: [ComboBox] Follow focusPolicy

broulik added a comment. Ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24879 To: broulik, #plasma Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24879: [ComboBox] Follow focusPolicy

broulik added a comment. In D24879#552657 , @apol wrote: > Wouldn't it make more sense to not accept the event then? Not sure. The main reason for the `MouseArea` (apart from wheel handling) seems to be opening the `ComboBox` on *press*.

D24879: [ComboBox] Follow focusPolicy

apol added a comment. Wouldn't it make more sense to not accept the event then? INLINE COMMENTS > ComboBox.qml:79 > onPressed: { > +if ((controlRoot.focusPolicy & Qt.ClickFocus) === Qt.ClickFocus) > { > +controlRoot.forceActiveFocus(); `if

D24879: [ComboBox] Follow focusPolicy

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a `MouseArea` in our `contentItem` stealing events from the underlying `Control`,