D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham added a comment. The desktop effects KCM doesn't have a centered form layout like this one does. I tried a left-aligned label but it looked quite odd. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc:

D24906: [KCMs/Night Color] Explain Night Color feature inline

GB_2 added a comment. In the Desktop Effects KCM the label is top-left aligned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc: GB_2, ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n,

D24906: [KCMs/Night Color] Explain Night Color feature inline

This revision was automatically updated to reflect the committed changes. Closed by commit R119:af39f0aeaf93: [KCMs/Night Color] Explain Night Color feature inline (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham updated this revision to Diff 68704. ngraham added a comment. Tweak wording and set a maximum width for the label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24906?vs=68646=68704 BRANCH explain-night-color (branched from master)

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham added a comment. In D24906#553215 , @ahiemstra wrote: > Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means? I would hope so; warm vs

D24906: [KCMs/Night Color] Explain Night Color feature inline

ahiemstra added a comment. Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means? REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL

D24906: [KCMs/Night Color] Explain Night Color feature inline

davidedmundson added a comment. > They prefer, correct me if I'm wrong, something like "[Night Color KCM]". Plasma folks don't really have a good style sorted. You can find examples of 3 different styles. It is a good point that we miss a consistency :/ but it also means no

D24906: [KCMs/Night Color] Explain Night Color feature inline

davidedmundson added a comment. > They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc:

D24906: [KCMs/Night Color] Explain Night Color feature inline

zzag added a comment. > [KCMs/Night Color] Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY All the other platforms that have implemented this feature offer a little inline

D24906: [KCMs/Night Color] Explain Night Color feature inline

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I was going to suggest that we use the module subtitle for this, but it looks like we don't use those anymore. REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from