D24916: KCM style : fix combobox that weren't updated after user made change

crossi abandoned this revision. crossi added a comment. Fix by D25000 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. Once we got D25000 completed, please remember to abandon that one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel, LeGast00n,

D24916: KCM style : fix combobox that weren't updated after user made change

crossi updated this revision to Diff 68755. crossi added a comment. qml style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24916?vs=68748=68755 REVISION DETAIL https://phabricator.kde.org/D24916 AFFECTED FILES

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > It's likely we'll encounter that ComboBox breakage at other places. we do :) https://cgit.kde.org/kscreen.git/tree/kcm/package/contents/ui/Panel.qml?id=7811411c6425dd52bcd732a5910d177fee4a89d2#n42 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. Style wise, functions come before children objects. Other than that looks good to me. Through Kai comments, the question also becomes, wouldn't it be better to fix the root cause? It's likely we'll encounter that ComboBox breakage at other places. REPOSITORY

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553958 , @broulik wrote: > > Ah somehow I thought we had a third more "clever" case of currentIndex moving. > > Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :(

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > Ah somehow I thought we had a third more "clever" case of currentIndex moving. Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :( So best hack would be to have a c++ thing that sets the property without going

D24916: KCM style : fix combobox that weren't updated after user made change

crossi updated this revision to Diff 68748. crossi added a comment. refactor code into a function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24916?vs=68670=68748 REVISION DETAIL https://phabricator.kde.org/D24916 AFFECTED FILES

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553919 , @broulik wrote: > > AFAICT it won't be pretty though. :-) > > I think it's pretty straightforward > 1.) the delegate must not explicitly set a `currentIndex` because Qt does it for us, see D18299

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > AFAICT it won't be pretty though. :-) I think it's pretty straightforward 1.) the delegate must not explicitly set a `currentIndex` because Qt does it for us, see D18299 2.) the wheel handler must be changed to call

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553886 , @broulik wrote: > Hm I think qqc2-desktop-style breaks the binding on `currentIndex`, otherwise this would not be neccessary... Good point... What about fixing that? AFAICT it won't be pretty

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. Hm I think qqc2-desktop-style breaks the binding on `currentIndex`, otherwise this would not be neccessary... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel,

D24916: KCM style : fix combobox that weren't updated after user made change

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > EffectSettingsPopup.qml:72 > +onMainToolBarStyleChanged: { > +mainToolBarStyleCombo.currentIndex = >

D24916: KCM style : fix combobox that weren't updated after user made change

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. TEST PLAN Inside Configure Icons and Toolbars popup menu, change some value in combobox, hit