D24924: Don't reset model when adding an active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:6929300787ac: Don't reset model when adding an active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68695. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68691&id=68695 BRANCH updavail REVISION DETAIL

D24924: Don't reset model when adding an active connection

jgrulich added a comment. In D24924#553460 , @jgrulich wrote: > Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically. Can you change it in other PRs too and

D24924: Don't reset model when adding an active connection

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically. REPOSITORY R116 Plasma Network Manage

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68691. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68681&id=68691 BRANCH updavail REVISION DETAIL https://phabricat

D24924: Don't reset model when adding an active connection

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:313 > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(row, 0)); > } Shouldn't you add it

D24924: Don't reset model when adding an active connection

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 REPOSITORY R116 Plas