D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra added a comment. @jjorge: I had to manually edit your author information into the commit, since that got lost somewhere along the way and replaced with our localization script info. I think it is OK now, but please check

D25018: Move ACPI battery information from /proc/acpi to /sys

This revision was automatically updated to reflect the committed changes. Closed by commit R106:9022a93738df: Move ACPI battery information from /proc/acpi to /sys (authored by l10n daemon script scri...@kde.org, committed by ahiemstra). CHANGED PRIOR TO COMMIT

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. In D25018#562834 , @ahiemstra wrote: > Do you have a developer account to push the changes? Otherwise I can do that for you. I don't, so yes please do the push. REPOSITORY R106 KSysguard BRANCH

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra added a comment. KSysGuard is part of Plasma, so these changes will not be released until the next plasma release, which is 5.18 and should be released I think January next year. Do you have a developer account to push the changes? Otherwise I can do that for you. REPOSITORY

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. How will this be merged? Will it be in time for Kde 19.12 ? REPOSITORY R106 KSysguard BRANCH acpi-move-battery-to-sysfs REVISION DETAIL https://phabricator.kde.org/D25018 To: jjorge, davidedmundson, #plasma, ahiemstra Cc: alexde, plasma-devel, LeGast00n,

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. > How can you interpret these weird charge_now values correctly? If the range is [1/1000, 901] Wh, while the real range is [0, 45] Wh, how does the charge curve look like while charging or discharging? Are there (continues) values in [46, 901] Wh? Do you assume all

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added a comment. In D25018#561268 , @jjorge wrote: > > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > > Yes : this is a percentage. States out of this value are bad

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge marked an inline comment as done. jjorge added a comment. > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? Yes : this is a percentage. States out of this value are bad hardware : I have a travel battery which shows

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added inline comments. INLINE COMMENTS > acpi.c:129 > +} else if (state < 0) { > +state = 0; /* prevent insane numbers with bad hardware */ > } Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > acpi.c:161

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. Thanks. Just some thoughts : designcharge is usefull if you want to see the percentage of charge you reach against what it should be with a new battery. For some adicional sensors, of course, even if I dont see what ones you are thinking about. REPOSITORY R106

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. So, with this my system lists battery in ksysguard again, which is really nice. I do wonder about the usefulness of the "DesignCharge" sensor and would maybe like to see some

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge updated this revision to Diff 69357. jjorge marked 6 inline comments as done. jjorge added a comment. - hopefully correct all problems found in nice ahiemstra's revision - - indentation corrected to 4 chars - - function braces in newline - - We can calculate charge even if current

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra added a comment. You are right, sorry. I was confusing /sys with /proc, which does have a lot of "put all of this information in a single file" stuff going on. It would still be nice if there was a better way of getting this information, but that is not related to this change. So

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. In D25018#558503 , @ahiemstra wrote: > Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge requested review of this revision. jjorge added a comment. So asking again for feedback, if I understand well how phabricator works ... REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D25018 To: jjorge, davidedmundson, #plasma, ahiemstra Cc: plasma-devel,

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over.

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY Since kernel 2.6.24 in 2008, the /proc/acpi/battery interface is deprecated. There is for years no updated kernel which wouldn't